Skip to content

feat: refine proxy group member controls#52

Closed
AAEE86 wants to merge 1 commit into
SubBoost:mainfrom
AAEE86:main
Closed

feat: refine proxy group member controls#52
AAEE86 wants to merge 1 commit into
SubBoost:mainfrom
AAEE86:main

Conversation

@AAEE86

@AAEE86 AAEE86 commented Jul 6, 2026

Copy link
Copy Markdown

Split advanced proxy group members into node and rule group sections, with separate clear actions for enabled nodes and enabled rule groups.

Update proxy group summaries to show routing rules, nodes, and rule sets as separate counts.

Split advanced proxy group members into node and rule group sections, with separate clear actions for enabled nodes and enabled rule groups.

Update proxy group summaries to show routing rules, nodes, and rule sets as separate counts.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c85f282984

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Ryson-32

Copy link
Copy Markdown
Contributor

Thanks for this, @AAEE86 — appreciate you digging into the proxy group summaries.

Your PR surfaced something we'd missed: the member count on each group card was inflated, because it counted every entry (including DIRECT/REJECT fallbacks and references to other groups) as a node. We've fixed that, and the correction will ship in an upcoming release — the node count now reflects real nodes only.

We're going to hold off on the rest, for two reasons:

  • The split member sections with separate clear actions overlap with member controls that recently landed through a different implementation.
  • The extra "规则集 (rule set)" count is a conceptual mismatch: non-node entries in a group's member list are references to other proxy groups, not rule sets — and "规则集" already refers to the rule-provider URL elsewhere on this page, so a second, different "规则集" count would be confusing. For most default groups it would also read 0, or an inaccurate 1 from the fallback entries.

So we'll carry the accurate node count forward and close this out here. Thanks again for catching the counting issue — it's a real improvement. 🙏

@Ryson-32 Ryson-32 closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants