Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 473a0c2cf3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| is_official_fixed_release_url() { | ||
| case "$1" in | ||
| https://github.com/SubBoost/subboost/releases/download/v[0-9]*.[0-9]*.[0-9]*/release.json) return 0 ;; |
There was a problem hiding this comment.
For installations intentionally pinned to an official prerelease asset such as https://github.com/SubBoost/subboost/releases/download/v2.6.0-beta.1/release.json, this shell glob still matches because [0-9]* means “a digit followed by arbitrary characters,” not “digits only.” update_cmd then rewrites SUBBOOST_RELEASE_URL to the stable latest manifest before fetching, unexpectedly moving prerelease users off their selected channel instead of only migrating old fixed stable tags.
Useful? React with 👍 / 👎.
| local release_file="$TMP_DIR/release.json" | ||
| local image compose_url manager_url | ||
| mkdir -p "$TMP_DIR" | ||
| if migrate_update_release_url "$release_url"; then |
There was a problem hiding this comment.
When an old fixed official URL is detected but .env cannot be rewritten (for example because sudo is unavailable or permissions changed), invoking the side-effecting migration from an if condition suppresses errexit inside that function, so a failed write_runtime_env_value just makes the condition false and update_cmd continues with the old pinned URL after printing the migration message. This can leave the installation unmigrated instead of failing clearly at the point where the release source could not be saved.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation