Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0933072c4f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - Existing v2.4.0 self-hosted installations can continue to update with `subboost update`. | ||
| - Normal subscription conversion, templates, and rules do not require manual environment-variable changes. | ||
| - If you used filtered proxy groups in v2.4.0, open the custom proxy group editor after upgrading and check the generated output. Recreate those groups with the new advanced proxy group controls if needed. | ||
| - Existing filtered proxy groups will migrate to custom proxy groups automatically. If you used filtered proxy groups in v2.4.0, open the custom proxy group editor after upgrading and check the result. You may need to reconfigure them if the output is not what you expect. |
There was a problem hiding this comment.
This is not currently true for v2.4 configs that still contain the legacy filteredProxyGroups field: repo-wide search only finds that field in the removed-template-field list/docs, validateSubBoostTemplateConfig rejects it as removed (packages/core/src/templates/config-template.ts:33-38), and the generation normalizers build groups from customProxyGroups rather than migrating filteredProxyGroups (packages/core/src/rules/rule-model.ts:105-120, packages/core/src/subscription/config-utils.ts:247-251). Users relying on this upgrade note may skip manually recreating or exporting filtered groups and then find those groups missing after upgrade.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation