Skip to content

Fix postMessage origin bypass and playsound DOM XSS (master source) - #3798

Merged
nao-pon merged 1 commit into
Studio-42:masterfrom
wpexpertsio:fix/security-postmessage-playsound-xss-master
Aug 3, 2026
Merged

Fix postMessage origin bypass and playsound DOM XSS (master source)#3798
nao-pon merged 1 commit into
Studio-42:masterfrom
wpexpertsio:fix/security-postmessage-playsound-xss-master

Conversation

@wpexpertsio

Copy link
Copy Markdown
Contributor

Summary

  • Apply the same security fixes from Fix postMessage origin bypass and playsound DOM XSS聽#3797 to the master source file js/elFinder.js
  • Replace prefix indexOf(origin) with exact URL.origin matching
  • Prevent playsound DOM XSS via filename allowlist + DOM APIs
  • Sanitize untrusted bind from postMessage payloads

Follow-up to #3797 as requested: the previous change landed on 2.1-src (generated build), so this PR targets master source.

Test plan

  • Same-origin / connector-origin postMessage still works
  • Prefix attacker origin is rejected
  • Malicious soundFile does not inject HTML / XSS
  • Normal rm.wav still plays when sound is enabled

Credit

WPExperts / Advanced File Manager

Co-authored-by: Cursor <cursoragent@cursor.com>
@nao-pon
nao-pon merged commit 683cbe5 into Studio-42:master Aug 3, 2026
3 checks passed
@nao-pon

nao-pon commented Aug 3, 2026

Copy link
Copy Markdown
Member

@wpexpertsio Thanks for creating a new PR against master, and sorry for the extra work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants