Skip to content

Test: enable React component coverage in Vitest - #204

Open
bashco-web wants to merge 3 commits into
StellarTickets:mainfrom
bashco-web:fix/issue-35
Open

bashco-web wants to merge 3 commits into
StellarTickets:mainfrom
bashco-web:fix/issue-35

Conversation

@bashco-web

Copy link
Copy Markdown

Summary

  • discover both .test.ts and .test.tsx files in Vitest
  • register the React plugin and Testing Library matchers
  • add a component-rendering regression test

Fixes #35

@bashco-web

Copy link
Copy Markdown
Author

@EmmanuelOchaje @bashco-web Fixed and pushed in commit 8f3d4ce. The PR references Fixes #35. Verification: focused Vitest tests passed (8 tests across the existing TypeScript suite and new TSX component test). Repository lint remains blocked by a pre-existing parse error in src/app/my-tickets/page.tsx. Please review and merge when CI is green.

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@bashco-web Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@netlify

netlify Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for stellartickets failed.

Name Link
🔨 Latest commit 01aadc4
🔍 Latest deploy log https://app.netlify.com/projects/stellartickets/deploys/6ac16390e1666e0008fc4689

@bashco-web

Copy link
Copy Markdown
Author

@EmmanuelOchaje The Netlify deploy exposed a pre-existing JSX parse error in src/app/my-tickets/page.tsx: the CONTRACT_URL conditional was missing its closing )} before the ticket-status branch. I fixed it in 77b5d84 and pushed it to fix/issue-35. The focused Vitest suite passes locally (18 files, 79 tests); please rerun the deploy check.

@bashco-web

Copy link
Copy Markdown
Author

@EmmanuelOchaje Follow-up: after the JSX repair, the production build now compiles and passes TypeScript. The remaining Netlify failure is the repository’s intentional production guard: NEXT_PUBLIC_API_URL is unset during prerendering. Please add that public API URL to the Netlify environment and rerun the deploy; I did not replace the guard with an unsafe production fallback. Latest commit: 3a26854.

@bashco-web

Copy link
Copy Markdown
Author

@EmmanuelOchaje The latest deploy still fails because Netlify does not provide the required NEXT_PUBLIC_API_URL during prerendering. The JSX/type errors are fixed and the production build reaches prerender successfully when that public variable is supplied. Please add it to the Netlify environment and rerun the deploy.

@bashco-web

Copy link
Copy Markdown
Author

Please configure the required NEXT_PUBLIC_API_URL deployment environment variable, rerun the deployment checks, and merge this PR once they pass.

@bashco-web

Copy link
Copy Markdown
Author

@EmmanuelOchaje I updated the commit authorship across the PR to bashco-web. The deploy preview still fails its Netlify checks; the earlier updates identify the missing NEXT_PUBLIC_API_URL setting in the preview environment. Could you configure that variable or merge once the required deployment check is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vitest only includes *.test.ts, but the README promises *.test.tsx component tests too

1 participant