fix(my-tickets): don't report a confirmed action as failed when the reload fails - #195
Merged
presidojay1 merged 2 commits intoSep 26, 2026
Merged
Conversation
Reloads /tickets/mine and reports a failed reload as 'done, but the list could not refresh' rather than as a failure of the action itself.
…d fails Move the post-action list reload out of the transfer / list-for-resale / cancel-resale try blocks so a failed refresh can no longer trigger the 'Could not ...' error for an action that already succeeded on-chain.
|
@Smoothjane Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for stellartickets failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
src/app/my-tickets/page.tsx, the list reload after an action ran inside the sametryas the on-chain transfer, list-for-resale, or cancel-resale. That action is already confirmed when the reload runs. So if the refresh then failed, the user could see an error on the page for a ticket action that had actually gone through, and might retry it.Fix
reloadAfterAction(doneMessage)helper. It re-fetches/tickets/mine.handleTransfer,handleListForResale,handleCancelResale:doneMessageinside itstryoncesignAndSubmitresolves.try/catch/finally, it callsreloadAfterAction(doneMessage), and only if the action succeeded. A reload failure can no longer reach the action'scatch.busyTicketIdhandling are unchanged.Commits
feat(my-tickets): add reloadAfterAction helper for post-action refreshfix(my-tickets): don't report a confirmed action as failed when reload failsNotes
main,page.tsxalready contains leftover merge conflict lines. There are duplicateimport type { Ticket }lines, and repeatedhandleTransfer/handleListForResalesignatures. These predate this PR and are outside its scope. This PR only touches the reload flow, but those lines will need a separate cleanup before the page type-checks.node_modulesin my checkout).Closes A successful action is reported as failed if the follow-up reload fails (My tickets) #62
Closes A successful publish/issue is reported as failed if
loadEvent()fails afterwards #63Closes Check the connected Freighter account matches the account saved on the profile before signing #64
Closes Warn when Freighter is on a different Stellar network than the app #65