Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
Summary
Resolves a control-flow bug in
src/hooks/useRetry.tswhererun()early returns upon successful execution inside the retry loop, skipping the trailingsetLoading(false)statement and leaving components with stuckloading: truestate.Key Changes
•
useRetryControl Flow (src/hooks/useRetry.ts):try { ... } finally { setLoading(false); }block to guaranteeloadingstate is reset tofalseregardless of whetherrun()returns early after a successful call or finishes after exhausting retries.• Unit Test Suite (
src/hooks/useRetry.test.ts):loadingresets tofalseon immediate success.loadingresets tofalseon success after transient retry.loadingresets tofalseand setserrormessage when all retries are exhausted.Quality Verification
npx vitest run src/hooks/: 29/29 tests passing across all hook test suites (100% pass rate).git diff --check: 0 formatting / whitespace errors.