fix(auth): map unique email violation to Conflict on register (#55) - #82
Open
Simultech369 wants to merge 1 commit into
Open
Simultech369 wants to merge 1 commit into
Simultech369 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #55 by catching PostgreSQL unique constraint violations on
INSERT INTO usersduring registration and mapping them to HTTP409 Conflict(AppError::Conflict("Email".into())), matching the semantic behavior of the preliminary existence check and eliminating spurious500 INTERNAL_SERVER_ERRORresponses under concurrent registration races.Changes
src/error.rs):is_unique_violation(error: &sqlx::Error) -> boolfromsrc/services/batch.rstosrc/error.rs.batch.rsandroutes/auth.rs.src/routes/auth.rs):SELECT EXISTScheck as an optimization to avoid paying unnecessary bcrypt hashing computation costs for obvious duplicates.INSERT INTO usersquery execution with.map_err(...):is_unique_violation(&e)is true, maps toAppError::Conflict("Email".into())(HTTP 409).AppError::Database(e)(HTTP 500).src/error.rs):test_conflict_status_and_code: AssertsAppError::Conflictmaps toStatusCode::CONFLICTand machine-readable code"CONFLICT".test_is_unique_violation_non_db_error: Asserts non-unique errors (e.g.RowNotFound) evaluate tofalse.cargo test.Closes #55
Stellar Payout (GrantFox):
GCK7WCZCOFNYXTH74KADMAIREIJKHIAX4ISJSGXZ4IF2MIRGAFLT4BTHBase USDC:
0xEa3A353Fb3fc88DB8F0FA1E6Ea541FEdc9F5F0E7