feat(compare): add /compare#864
Draft
ugcodrr wants to merge 4 commits into
Draft
Conversation
- Extract getBedWarsTable() from BedWarsProfile into a StatColumn[][] descriptor so stat layout is defined once and consumed by both the normal profile and the new compare profile - Add SplitPill component: split value box with per-player coloring (§a better / §c worse / §f equal) and ▲/▼ delta row - Add generic CompareProfile driven purely by the descriptor; no per-game renderer files needed - Add CompareCommand with @subcommand bedwars; player2 defaults to the caller's linked account via existing missingSelfVerification logic - Add compare / compare-command / compare-bedwars i18n keys (en-US) - pnpm lint and pnpm test:types pass Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fetch both players' head images (HEAD_SIZE=32px) in parallel with the logo in the shared run() path, so every future game subcommand inherits heads with no per-game work. Heads are passed as Image|null — a failed fetch degrades gracefully to name-only display via the nameRow array conditional. API base comes from the existing config-driven getPlayerHead() on ApiService (same pattern as getPlayerSkin). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ugcodrr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
descriptor so stat layout is defined once and consumed by both the
normal profile and the new compare profile
(§a better / §c worse / §f equal) and ▲/▼ delta row
per-game renderer files needed
the caller's linked account via existing missingSelfVerification logic
TODO: