feat(gamecounts): add mode filter option#842
Open
ugcodrr wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
ugcodrr
force-pushed
the
feat/gamecounts-mode-filter
branch
from
7a9e95d to
1a0d768
Compare
* Change selectedGame type to string for better flexibility * Update game count pagination to handle selectedGame validation * Enhance createGameCountsPage to optionally show title emoji
There was a problem hiding this comment.
Pull request overview
This PR adds a /gamecounts autocomplete option for selecting a specific game and fixes command change detection so commands repost when options are added to previously optionless commands.
Changes:
- Adds a
modeautocomplete argument to/gamecounts. - Renders a single selected game count page when a valid mode is provided, while preserving the existing overall paginated view.
- Updates command equality logic and adds test coverage for detecting newly added arguments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/discord-bot/src/commands/gamecounts.command.ts |
Adds gamecount mode autocomplete and selected-game rendering. |
packages/discord/src/command/command.resolvable.ts |
Fixes option count comparison during command equality checks. |
packages/discord/src/command/command.builder.ts |
Adds a test for detecting added command arguments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary