Repository navigation
Improve reranker ordering, low-confidence threshold and memory use - #1
Merged
Merged
Conversation
- Order reranked candidates by 1/(1 + reranker rank) + 0.5/(1 + retrieval rank) instead of by the reranker score alone. The reranker gives many candidates a probability close to 1, so ordering by it alone could push the best retrieval match out of the top results. - Write low_confidence_below: 0.9 instead of 0.5 into new indexes. Queries for results in StatLean score close to 1, so the higher threshold also flags queries for results StatLean does not contain that score between 0.5 and 0.9. - Compute reranker logits for the last position only. Full-sequence logits took about 3 GB per batch of ten 1024-token prompts in half precision and ran out of memory on 11 GB GPUs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1/(1 + reranker rank) + 0.5/(1 + retrieval rank)instead of by the reranker score alone. The reranker gives many candidates a probability close to 1, so ordering by it alone could push the best retrieval match out of the top results.low_confidence_below: 0.9instead of 0.5 into new indexes. Queries for results in StatLean score close to 1, so the higher threshold also flags queries for results StatLean does not contain that score between 0.5 and 0.9. Search reads the threshold from each index'sindex.json, so indexes built before this change keep 0.5.logits_to_keep=1). Full-sequence logits took about 3 GB per batch of ten 1024-token prompts in half precision and ran out of memory on 11 GB GPUs.Checks
pytestandpyflakes src teststest_real_hybridwith a hybrid index of StatLeane436d8a1on an RTX A6000