Repository navigation
Native navigation runtime shell - #23
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86f9869c9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| private void applyContentInsets() { | ||
| FrameLayout.LayoutParams params = (FrameLayout.LayoutParams) content.getLayoutParams(); | ||
| params.topMargin = topEnabled ? dp(TOP_BAR_DP) : 0; |
There was a problem hiding this comment.
When SIDEBAR_NAVIGATION_ENABLED is true and TOP_NAVIGATION_ENABLED is false, buildTopBar() displays the 48dp launcher but this leaves the content's top margin at zero. The launcher consequently covers and intercepts taps on the WebView's top-left content; reserve space for the standalone launcher or place it in a non-overlaid bar.
Useful? React with 👍 / 👎.
| if (nativeNavigation != null && webView != null) { | ||
| nativeNavigation.updateHistoryState(webView.getUrl()); |
There was a problem hiding this comment.
The navigation state is refreshed only from onPageReady(), which is driven by WebViewClient.onPageFinished(). Routes changed through history.pushState, replaceState, or same-document navigation do not reliably finish a page load, so SPA navigation can leave Back disabled and the selected bottom tab stale even though the WebView history and URL have changed; propagate doUpdateVisitedHistory or an equivalent route-change callback to updateHistoryState().
Useful? React with 👍 / 👎.
| private TextView actionText(String label, int widthDp) { | ||
| TextView view = new TextView(context); | ||
| view.setText(label); | ||
| view.setTextColor(foregroundColor); |
There was a problem hiding this comment.
When TalkBack or another accessibility service is enabled, these controls expose only Unicode glyphs such as ‹, ⌂, and ↻, so they are announced as punctuation or symbol names rather than Back, Home, and Reload. Pass a semantic accessibility label for each icon action and set it as the content description so users can identify the native navigation controls.
Useful? React with 👍 / 👎.
Adds real native Top Bar, Sidebar, Bottom Tabs and Contextual Toolbar support. Sidebar and Bottom Tabs share trusted profile-defined navigation destinations, Contextual Toolbar provides Back/Home/Reload/Forward, and native surfaces reserve WebView layout space. Includes pure-Java menu parsing/URL resolution tests and keeps Android 6/API 23 compatibility.