Repository navigation
Runtime theme controls and page transitions #22
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package de.starlightunit.wrapper.ui; | ||
|
|
||
| import android.view.View; | ||
|
|
||
| public final class PageTransitionController { | ||
| private static final long DURATION_MS = 140L; | ||
|
|
||
| private final View content; | ||
| private final boolean enabled; | ||
|
|
||
| public PageTransitionController(View content, boolean enabled) { | ||
| this.content = content; | ||
| this.enabled = enabled; | ||
| } | ||
|
|
||
| public void onPageLoading() { | ||
| content.animate().cancel(); | ||
| if (!enabled) { | ||
| content.setAlpha(1f); | ||
| return; | ||
| } | ||
| content.setAlpha(0.72f); | ||
| } | ||
|
|
||
| public void onPageReady() { | ||
| content.animate().cancel(); | ||
| if (!enabled) { | ||
| content.setAlpha(1f); | ||
| return; | ||
| } | ||
| content.animate().alpha(1f).setDuration(DURATION_MS).start(); | ||
| } | ||
|
|
||
| public void reset() { | ||
| content.animate().cancel(); | ||
| content.setAlpha(1f); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package de.starlightunit.wrapper.ui; | ||
|
|
||
| import java.util.Locale; | ||
|
|
||
| public final class SystemBarStyle { | ||
| private SystemBarStyle() { | ||
| } | ||
|
|
||
| public static int parseRgb(String value, int fallback) { | ||
| if (value == null) { | ||
| return fallback; | ||
| } | ||
| String normalized = value.trim().toLowerCase(Locale.ROOT); | ||
| if (!normalized.matches("^#[0-9a-f]{6}$")) { | ||
| return fallback; | ||
| } | ||
| try { | ||
| return 0xff000000 | Integer.parseInt(normalized.substring(1), 16); | ||
| } catch (NumberFormatException ignored) { | ||
| return fallback; | ||
| } | ||
| } | ||
|
|
||
| public static boolean shouldUseDarkIcons(int argb) { | ||
| double r = ((argb >> 16) & 0xff) / 255.0; | ||
| double g = ((argb >> 8) & 0xff) / 255.0; | ||
| double b = (argb & 0xff) / 255.0; | ||
| double luminance = (0.2126 * linearize(r)) | ||
| + (0.7152 * linearize(g)) | ||
| + (0.0722 * linearize(b)); | ||
| return luminance > 0.55; | ||
| } | ||
|
There was a problem hiding this comment.
For common mid-light configured colors, this cutoff selects light icons even when they have very poor contrast. For example, Useful? React with 👍 / 👎. |
||
|
|
||
| private static double linearize(double value) { | ||
| return value <= 0.03928 | ||
| ? value / 12.92 | ||
| : Math.pow((value + 0.055) / 1.055, 2.4); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| package de.starlightunit.wrapper.web; | ||
|
|
||
| import android.content.Context; | ||
| import android.content.res.Configuration; | ||
| import android.webkit.WebSettings; | ||
|
|
||
| import androidx.webkit.WebSettingsCompat; | ||
| import androidx.webkit.WebViewFeature; | ||
|
|
||
| import java.util.Locale; | ||
|
|
||
| import de.starlightunit.wrapper.config.AppConfig; | ||
|
|
||
| public final class WebThemeController { | ||
| public static final String MODE_DARK = "dark"; | ||
| public static final String MODE_LIGHT = "light"; | ||
| public static final String MODE_AUTO = "auto"; | ||
|
|
||
| private WebThemeController() { | ||
| } | ||
|
|
||
| public static void configure(Context context, WebSettings settings) { | ||
| String mode = normalize(AppConfig.WEB_DARK_MODE); | ||
| boolean systemDark = (context.getResources().getConfiguration().uiMode | ||
| & Configuration.UI_MODE_NIGHT_MASK) == Configuration.UI_MODE_NIGHT_YES; | ||
| boolean dark = resolveDark(mode, systemDark); | ||
|
|
||
| if (WebViewFeature.isFeatureSupported(WebViewFeature.ALGORITHMIC_DARKENING)) { | ||
| WebSettingsCompat.setAlgorithmicDarkeningAllowed(settings, dark); | ||
| return; | ||
|
Comment on lines
+28
to
+30
There was a problem hiding this comment.
When a profile selects Useful? React with 👍 / 👎. |
||
| } | ||
|
|
||
| if (WebViewFeature.isFeatureSupported(WebViewFeature.FORCE_DARK)) { | ||
| WebSettingsCompat.setForceDark( | ||
| settings, | ||
| dark ? WebSettingsCompat.FORCE_DARK_ON : WebSettingsCompat.FORCE_DARK_OFF | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| static String normalize(String value) { | ||
| String normalized = value == null ? "" : value.trim().toLowerCase(Locale.ROOT); | ||
| switch (normalized) { | ||
| case MODE_LIGHT: | ||
| case MODE_AUTO: | ||
| case MODE_DARK: | ||
| return normalized; | ||
| default: | ||
| return MODE_DARK; | ||
| } | ||
| } | ||
|
|
||
| static boolean resolveDark(String configuredMode, boolean systemDark) { | ||
| String mode = normalize(configuredMode); | ||
| if (MODE_LIGHT.equals(mode)) { | ||
| return false; | ||
| } | ||
| if (MODE_AUTO.equals(mode)) { | ||
| return systemDark; | ||
| } | ||
| return true; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a cold launch with a nonblack
SPLASH_BACKGROUND_COLOR, Android displays the activity's starting window beforeonCreate()andsetContentView(), and that window still uses the hardcoded blackandroid:windowBackgroundfromTheme.StarlightUnit. Setting theImageViewbackground here happens too late to prevent the black launch frame, so the configured splash color should also be emitted into the launch/window theme.Useful? React with 👍 / 👎.