ci: validate music data Gekisou aptitude and gzip size - #4
Merged
Merged
Conversation
The deck gate checks the seeds (the one seed 0 on a chart without a luck range, else two or more different seeds, the same on every luck chart: their number is the file's, not fixed), every seed range's rank 1 bonus (trunc(rangeScore * rankBonusPercent / 100)) and its luckPoints, which nnnotes and ournotes-deck add with the Gekisou skills. RECIPE 2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nichinichisou0609
force-pushed
the
ci/music-data-gekisou
branch
from
September 29, 2026 19:17
5d60669 to
96ae15e
Compare
Author
|
Aptitude page smoke added in 445b963 (pure API from player 1522c24; production PLAYER_REF unchanged). Full existing deck output passes: 340 charts, 35 shapes, 8,476 variants (3,672 deterministic). 462 variants missed their SE target and are warnings only. Gzip level 6: wrapped file 1,370,474 bytes, aptitude 985,973 bytes, below the 2 MB / 1.2 MB caps. Joined read-only to existing song facts, the page smoke passes 2,380 baseline figures and 42,380 aptitude figures. Only deterministic check seeds are reconstructed; stochastic means are not used for individual checks. Full nnnotes export validation remains pending. Do not merge or publish. |
Check shape references, mission coverage, band variants, mean/error pairs, seed rules, dimensions, tail identities and simulation bounds. Cap gzip size at 2 MB overall and 1.2 MB for aptitude. Exercise page lookups, gains, uncertainty and missing cross terms. Default figures must remain unchanged. Reconstruct only deterministic check seeds with positional master skill factors, never stochastic means. Add a real chart-stats sample test and a necessary rounding bound for stochastic tailPerfect. Keep production PLAYER_REF and publishing unchanged. Co-Authored-By: Claude Code <noreply@anthropic.com>
nichinichisou0609
force-pushed
the
ci/music-data-gekisou
branch
from
September 29, 2026 20:49
445b963 to
4c22bfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Gekisou aptitude gates to the general seed, rank-bonus and luckPoints checks. RECIPE is 2; format remains nnnotes.music-data/1.
Validation
Rollout
Do not merge yet. Sync the upstream exporter/model first: older output lacks luckPoints and aptitude and is intentionally blocked. MUSIC_DATA_PUBLISH remains unset; no data uploads or workflow dispatches performed.
Generated with Claude Code