Fix Windows uninstall, shell-integration cleanup, and Windows autocomplete - #20
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR improves the install/uninstall lifecycle across platforms, focusing on making Windows uninstall reliable (despite locked running .exe files) and ensuring shell integration (PATH + autocomplete) is cleaned up symmetrically on uninstall. It also modernizes Docker provider defaults to work correctly on Windows by relying on Docker client environment/platform defaults rather than hard-coded unix sockets.
Changes:
- Implement Windows-safe uninstall by deleting config contents first (skipping the running binary) and scheduling post-exit removal of the locked
.exevia a detached helper. - Add symmetric shell-integration cleanup during uninstall (remove autocomplete blocks from shell rc/profile files and remove the Windows User PATH entry).
- Improve setup/install ergonomics: PowerShell completion installation on Windows and Docker client configuration (API negotiation + env/platform host defaults).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/npm-setup.mjs | Improves setup UX (TTY-safe spinner/progress) and adds better cross-platform dependency guidance; fixes Windows command spawning and PATH handling in the setup script. |
| internal/providers/docker.go | Switches Docker client to API version negotiation and uses env/platform default host when no socket is configured (fixes Windows). |
| internal/config/config.go | Makes Docker socket default empty so the Docker client selects the correct platform host / honors DOCKER_HOST. |
| cmd/stacyvm/cmd_uninstall.go | Implements config-dir deletion that skips the running binary; adds autocomplete-block removal helpers invoked during uninstall. |
| cmd/stacyvm/cmd_uninstall_windows.go | Adds Windows-specific shell cleanup and deferred self-delete via detached batch helper. |
| cmd/stacyvm/cmd_uninstall_unix.go | Adds Unix-specific shell cleanup and immediate unlink of the running binary. |
| cmd/stacyvm/cmd_uninstall_test.go | Adds unit tests for autocomplete-block removal across bash/fish/PowerShell and legacy cases. |
| cmd/stacyvm/cmd_setup.go | Adds Windows PowerShell completion install path discovery and writing to PowerShell profiles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- writePowerShellCompletion: handle WriteString/Close errors explicitly instead of deferring Close on a writable handle. - removeAutocompleteFromFile: preserve the existing file mode when rewriting so an 0600 profile isn't widened to 0644. - scheduleSelfDelete: use os.CreateTemp for a unique cleanup .bat name instead of a predictable, collision-prone temp filename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- sameFile: compare paths case-insensitively on Windows so a casing difference (e.g. drive letter) between os.Executable() and a directory walk doesn't make removeAllExcept fail to skip the locked running .exe. isWithin already folds case via filepath.Rel, so only this needs it. - isAutocompleteBlockLine: restrict the legacy no-terminator match set to StacyVM-specific tokens (stacyvm, .local/bin) so it can't delete unrelated user config lines containing generic tokens like source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Kaushik2003
marked this pull request as ready for review
June 3, 2026 21:25
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the install/uninstall lifecycle work correctly and symmetrically across Windows, macOS, and Linux.
.exe, soos.RemoveAll(configDir)aborted with "Access is denied" and left everything behind. Config/DB are now removed first (skipping the running exe), then a detached helper deletes the locked binary + directory once the process exits. Unix unlinks the running binary directly.# StacyVM Autocompleteblock from.bashrc/.zshrc/fish config, removes the.stacyvm\binentry from the Windows User PATH, and strips the PowerShell profile block — only touching StacyVM's own lines. Fixes the "stacyvm: command not found" noise in new shells after uninstall.setuppreviously only wrote to.bashrc/.zshrc/fish (absent on Windows), so completion was silently skipped. It now installs into the PowerShell profile(s) (powershell.exeandpwsh) via each shell's real$PROFILE.CurrentUserAllHosts.Testing
go vetpasses..stacyvmdir + PATH entry + profile block, with the profile restored byte-for-byte to its pre-install state.Closes #17
Closes #18
Closes #19