Breaking changes from ef-themes 2.0.0

[hollowsunhc]

Hi! I've noticed that the latest release of ef-themes does not have a definition for ef-themes--current-theme-palette, essentially breaking the bootstrap script!

I tried to pin down the commit in Emacs.org for 1.11.0 but the feature is experimental so I forked the repo and dropped commits until 1.11.0, then replaced call to add ef-themes package with

(use-package ef-themes
  :straight (:type git :host github :repo "hollowsunhc/ef-themes"
                   :branch "main2")
  :config
  (setq ef-duo-light-palette-overrides
        '((constant green))))

Have a good day!

[hollowsunhc]

Same goes for modus-themes. Had to downgrade to 4.8.1!

[SqrtMinusOne]

Yeah, I've been updating my config (and migrating to Arch from Guix) over the weekend and also noticed that.

Also, the colors seem to have changed somewhat, at least the light versions. Maybe that's because ef-themes is now based on modus-themes.

The following seems to work instead of ef-themes--current-theme-palette for both modus-themes and ef-themes:

(modus-themes-get-theme-palette
 (or (my/modus-p) (my/ef-p))
 :with-overrides :with-user-palette)

Where my/modus-p and my/ef-p are:

(defun my/modus-p ()
  (seq-find (lambda (x) (string-match-p (rx bos "modus") (symbol-name x)))
            custom-enabled-themes))

(defun my/ef-p ()
  (seq-find (lambda (x) (string-match-p (rx bos "ef") (symbol-name x)))
            custom-enabled-themes))

Because somehow it can't always detect the current theme.

Take a look at the arch branch if you want, I'll probably merge it this week when I migrate my main machine.

[hollowsunhc]

Thank you very much! I'm actually building this on arch so it happens that I can test 😄 although I'm a complete beginner with all of this!

First thing I've noticed is browser = /user/bin/firefox under .config/dunst/dunstrc. I believe it's usr , not user?

[SqrtMinusOne]

I believe it's usr , not user?

Yes, that's certainly right :-)

[hollowsunhc]

Thanks for the fixes! It works well. Last thing (out of context): Do you get "Buffer is Read-Only" errors in Firefox when activating char mode?

Thank you for this superb setup 😄

[SqrtMinusOne]

Do you get "Buffer is Read-Only" errors in Firefox when activating char mode?

I do, but very occasionally, and switching back and forth almost always fixes it. EXWM is somewhat flaky, unfortunately.