ci-local.sh proves the workflows parse; drop stray CHANGELOG heading - #84
Merged
Merged
Conversation
…ding The v0.9.4 CI outage (#82) was an unparseable ci.yml. GitHub failed the run at startup with zero jobs, so `test` and `okf-interop` stopped running for a week while pull requests still looked green. A workflow that cannot start cannot report its own breakage, so the check belongs where it runs before the push. tools/ci-local.sh already claims to run what the workflows run. Adds one step that yaml.safe_load parses every .github/workflows/*.yml and fails when the glob finds none. Negative-tested by reinjecting the exact #82 shape, a multi-line `python3 -c` at column 1 inside a `run: |` block: the step fails. Single-line `python3 -c` here for the same reason. Also removes the second `## Unreleased` heading in CHANGELOG.md. It dated from the 0.7.2 era and sat between the 0.7.3 and 0.7.2 sections. Its two bullets describe host manifests reaching 0.7.2, which shipped in 0.7.3, so they fold into the 0.7.3 list above them. The placeholder at the top stays. No assertion and no released behavior changes. Items 01M2XSTB63SP54A482P7GF95VD and 01M2XSTB8K5DMTPHVX3WR8QXSM. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#82 was an unparseable
ci.yml. GitHub failed the run at startup with zero jobs, sotestandokf-interopdid not execute for a week while pull requests still looked green. Onlyworklog.ymlreported, which is why nobody noticed.The fix for #82 shipped in v0.9.5. This adds the guard that makes the same class of defect fail loudly. A workflow that cannot start cannot check itself, so the check has to run before the push.
tools/ci-local.shalready states that it runs everything the workflows run.What
One step, placed first because a broken workflow means nothing else reaches CI:
It
yaml.safe_loads every.github/workflows/*.ymland fails when the glob finds none, so deleting the workflows cannot make it pass vacuously. Written as a single-linepython3 -c, which is the style the repo settled on after #82.Also removes the second
## Unreleasedheading inCHANGELOG.md. It dated from the 0.7.2 era and sat between the 0.7.3 and 0.7.2 sections. Its two bullets describe host manifests reaching 0.7.2, which shipped in 0.7.3, so they fold into the 0.7.3 list above. The intentional placeholder at the top is untouched.No assertion changed and no released behavior changed.
Verification
Negative test, the part that matters. Reinjecting the exact #82 shape, a multi-line
python3 -cat column 1 inside arun: |block, makes the new step fail:With the workflow restored,
tools/ci-local.shreports 26 passed, 1 failed.The one failure is pre-existing and not from this branch.
test_titleless_stem_match_is_invisible_on_every_enginefails the same way on cleanmain: on macOS/varis a symlink to/private/var, sorelative_to()raises. Linux CI has no such symlink, so it passes there. Worth a separate item.🤖 Generated with Claude Code