feat: open on-disk markdown links in the editor - #62
Open
RichardHightower wants to merge 2 commits into
Open
RichardHightower wants to merge 2 commits into
RichardHightower wants to merge 2 commits into
Conversation
01M3M9CAJ08DJKX7T6E0EE8SP3 Clicking a link loads that note when the href is a markdown file in the open folder. Directory paths like nested/note.md survive TipTap's URI check. A miss does not navigate the window away. Web links stay web links.
01M3M9CAJ08DJKX7T6E0EE8SP3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
01M3M9CAJ08DJKX7T6E0EE8SP3Click a link in the editor and, if it points at a markdown file on disk, Motion opens that note.
getting-started.md,nested/deeper.md,../welcome.md).md, folder links openREADME.mdorindex.mdfile://and absolute paths inside the folderdir/note.md. That check is replaced so those links stay links.Test plan
bun run typecheckbun run guard:clientbun test src(noteLink.test.ts)CI=1 playwright test e2e/links.spec.ts— 3 passed (sibling, nested, missing)