Repository navigation
Remove memcpy - #79
Merged
Merged
Conversation
Owner
|
Hi @stijnherfst, thanks for the collaboration! Everything looks good, my only "concern" is the stylistic change for the variable order declaration, this was to preserve the C89 support intact (although my most recent changes also break this accidentally, but it's trivial to fix). I really do not personally care, but the reasoning was to follow stb conventions, which SOIL mostly relies on. I don't think many people value C99 support at all these days, but give me a day to think about it, thanks! |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed a memcpy when directly uploading compressed textures using
SOIL_direct_load_DDS_from_memoryand also reworked the function somewhat to simplify the logic.Furthermore,
SOIL_free_image_datacan be removed asfree()is already a no-op for nullptr.And lastly I added the new header file to the CMake install list as that was breaking vcpkg builds.