Skip to content

🔒 Fix TOCTOU vulnerability in post deletion #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sparkier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 Fix TOCTOU vulnerability in post deletion #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/routes/api/post/[id]/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@ export const DELETE = async ({ locals: { supabase, safeGetSession }, params }) =
throw error(401, 'Unauthorized');
}

const { data: posts } = await supabase
const { error: deleteError, data } = await supabase
.from('post')
.select()
.delete()
.eq('id', params.id)
.eq('creator', session.user.email);
if (!posts?.length) {
throw error(404, 'Not found or unauthorized');
}

const { error: deleteError } = await supabase.from('post').delete().eq('id', params.id);
.eq('creator', session.user.email)
.select();

if (deleteError) {
throw error(500, 'Internal Server Error');
}

if (!data?.length) {
throw error(404, 'Not found or unauthorized');
}

return text('Post deleted');
};

Expand Down
7 changes: 4 additions & 3 deletions src/routes/api/post/[id]/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,11 @@ describe('PATCH /api/post/[id]', () => {
describe('DELETE /api/post/[id]', () => {
it('should throw 404 when deleting a non-existent post', async () => {
// Create a mock chain for supabase
const mockEq2 = vi.fn().mockResolvedValue({ data: [] });
const mockSelect = vi.fn().mockResolvedValue({ data: [], error: null });
const mockEq2 = vi.fn().mockReturnValue({ select: mockSelect });
const mockEq1 = vi.fn().mockReturnValue({ eq: mockEq2 });
const mockSelect = vi.fn().mockReturnValue({ eq: mockEq1 });
const mockFrom = vi.fn().mockReturnValue({ select: mockSelect });
const mockDelete = vi.fn().mockReturnValue({ eq: mockEq1 });
const mockFrom = vi.fn().mockReturnValue({ delete: mockDelete });

const mockSupabase = {
from: mockFrom
Expand Down
Loading