Skip to content

docs(fusa): [c-RCP-18-tracker Part 1] propagate tc18_master_id for REQ-CANEP-*/REQ-I2C-*/REQ-ISELED-*/REQ-LINEP-*/REQ-MDIO-*/REQ-ADC-* - #109

Merged
SoundMatt merged 2 commits into
mainfrom
tc18-533-propagate-canep-i2c-iseled-linep-mdio-adc-master-id
Aug 19, 2026
Merged

SoundMatt merged 2 commits into
mainfrom
tc18-533-propagate-canep-i2c-iseled-linep-mdio-adc-master-id

Conversation

@SoundMatt

Copy link
Copy Markdown
Owner

docs(fusa): [c-RCP-18-tracker Part 1] propagate tc18_master_id for REQ-CANEP-/REQ-I2C-/REQ-ISELED-/REQ-LINEP-/REQ-MDIO-/REQ-ADC-

This batch links 21 of the 32 requirements across REQ-CANEP-* (7),
REQ-I2C-* (5), REQ-ISELED-* (5), REQ-LINEP-* (4), REQ-MDIO-* (5), and
REQ-ADC-* (6) to their TC18 master-catalog clauses (RELAY's
docs/tc18-master-catalog.json), verified directly against TC18.txt
(the line-numbered plaintext extraction) and cpp-RCP's own
include/rcp/{can,i2c,iseled,lin,mdio,adc}.hpp headers and their
tests/test_*.cpp files — not copied from go-RCP's already-merged
equivalent batches, per the task's instruction to verify independently
since cpp-RCP's own wording/implementation choices can differ even
where the underlying TC18 clause is identical.

All six prefixes are the genuine per-endpoint-type TC18 packages (same
role as go-RCP's already-confirmed CAN/I2C/ISELED/LIN/MDIO/ADC
equivalents), not part of cpp-RCP's non-TC18 integration-shell set —
confirmed by reading each header's own doc comment, none of which
carries a TC18-scope disclaimer.

Linked (21):

REQ-LINEP-001 -> TC18-13.2-002 ep_type=0x06, Table 32 "ep_type values"
REQ-LINEP-002 -> TC18-13.7.10.3-001 Figure 39 raw "Lin payload" wire region, no PID/checksum/schedule sub-fields
REQ-LINEP-003 -> TC18-13.7.10.1-001 match-based reply behavior underlying responded/no-responded branching

REQ-CANEP-001 -> TC18-13.2-002 ep_type=0x0B, Table 32 "ep_type values"
REQ-CANEP-003 -> TC18-13.7.11.3-004 "Sending remote frames is not supported."
REQ-CANEP-004 -> TC18-13.7.11.3-002 CAN XL 2054-byte ceiling + segmentation requirement
REQ-CANEP-005 -> TC18-13.7.11.2-002 Table 56 CAN bit time registers 1/2/3 (Classical/FD/XL)
REQ-CANEP-006 -> TC18-13.7.11.2-002 Table 56 acceptance/receive filter register fields

REQ-ISELED-001 -> TC18-13.2-002 ep_type=0x0C, Table 32 "ep_type values"
REQ-ISELED-002 -> TC18-13.7.12.3-001 Figure 41 request shape (+ Figure 42 response shape cited in-text)
REQ-ISELED-003 -> TC18-13.7.12.3-004 "A response always contains the 12 bit address and 12 bit data plus the optional 4 bit CRC."
REQ-ISELED-004 -> TC18-13.7.12.1-002 "single trigger event ... when transmission ... has been completed"

REQ-MDIO-001 -> TC18-13.2-002 ep_type=0x0D, Table 32 "ep_type values"
REQ-MDIO-002 -> TC18-13.7.13.3-002 Table 60 mdio_payload width rules per mdio_mode

REQ-I2C-002 -> TC18-13.7.7.1-003 optional wait-for-bit-sequence request
REQ-I2C-003 -> TC18-13.7.7.3-001 transparent raw payload incl. address (Figure 30)
REQ-I2C-004 -> TC18-13.7.7.4-001 optional HW trigger event generation (Table 50's own Event column is blank in the extraction, so specific signal names are this implementation's own)

REQ-ADC-001 -> TC18-13.7.9.3-003 "A measured value may contain the average of multiple ADC samples..."
REQ-ADC-002 -> TC18-13.7.9.1-006 averaging-interval + COMBINE_NR_VAL clause (also corrects this entry's PRE-EXISTING tc18 citation, added before this batch: it quoted this exact text but misattributed it to §13.7.9.2 L5040 — verified against TC18.txt, the quote only occurs at §13.7.9.1 L5455-5457)
REQ-ADC-003 -> TC18-13.7.9.1-010 "The ADC only samples the input, when a request is executed..."
REQ-ADC-004 -> TC18-13.7.9.1-002 PWM-triggered ADC read concept

Deliberately skipped (11), with reasoning:

REQ-I2C-001 i2c_mode's coarse hs-bit decode is an explicitly
documented open item (header comment: "pending a
future spec errata pass") — no single TC18 clause
cleanly covers an intentionally-unresolved ambiguity.
REQ-I2C-005 boilerplate error-category/non-empty-message test,
no distinct TC18 clause.
REQ-CANEP-002 11-bit/29-bit CAN identifier numeric range boundaries
(0x7FF / 0x1FFFFFFF) are standard CAN-protocol facts;
TC18's own CAN section text only states "In case the
CAN ID is 11bits, then it shall be right aligned..."
(right-alignment, not range validation) and never
states the 29-bit extended range numerically anywhere
in the extraction — grepped TC18.txt to confirm no
"29-bit"/"29 bit"/"0x1FFFFFFF" text exists.
REQ-CANEP-007 Combines two things, neither independently citable:
(a) "CAN has no TriggerRegistry" is a structural
absence (TC18's CAN section genuinely has no trigger-
signal subsection, unlike I2C/ADC/UART/PWM), which
cannot be supported by a positive spec quote; (b) the
CanErrc-category half is the same boilerplate pattern
skipped everywhere else in this batch.
REQ-ISELED-005 boilerplate error-category test, no distinct TC18
clause.
REQ-MDIO-003 register write-then-read round-trip and "unwritten
register reads 0" are this implementation's own
internal-fidelity choices; TC18's MDIO section has no
register-persistence-semantics text to cite.
REQ-MDIO-004 (mdio_mode, mdio_address) register-space distinctness
is implementation-internal; MDIO's TC18 section
(13.7.13.1-.3) has no trigger-signal subsection at
all (unlike I2C/ADC/UART/PWM), so "notify
TransferComplete on every request" also has no TC18
basis to cite.
REQ-ADC-005 AdcErrc::no_signal is explicitly documented in
adc.hpp's own header comment as "an internal
condition... not a TC18 error code" (TC18's Table 27
error-code list has no ADC-specific no-signal entry)
— the missing-triggered-capture behavior this
requirement tests is this implementation's own choice,
not a spec clause.
REQ-ADC-006 boilerplate error-category test, no distinct TC18
clause.
REQ-LINEP-004 boilerplate error-category test, no distinct TC18
clause.

Citation correction found: REQ-ADC-002's tc18 field (added before this
batch, likely from an earlier ADC-focused pass — this batch found it
already present but WITHOUT a tc18_master_id) cited "§13.7.9.2 ...
TC18.txt L5040" for the "an implementation may decide to fix" quote.
Verified against TC18.txt directly: that quote exists exactly once, at
§13.7.9.1 L5455-5457, not §13.7.9.2, and not at L5040. Corrected in
this commit alongside adding the missing tc18_master_id.

Drift finding (not corrected, out of this pass's metadata-only scope):
REQ-ISELED-004's title/text still describe a NativeCrcError trigger
signal and IseledErrc::native_crc_mismatch error that
include/rcp/iseled.hpp's own header comment documents were removed by
the issue #71/cpp-RCP-02 wire-format fix (the invented CRC-8 was
removed because this repo has no verified copy of the real ISELED CRC
algorithm). tests/test_iseled.cpp's REQ-ISELED-004 case now only
exercises the single surviving TransferComplete signal. This entry is
still linkable (TC18-13.7.12.1-002, "single trigger event ... when
transmission ... has been completed" matches the current, narrower
tested behavior), but its title/text predate that fix and should be
updated by a future pass; flagged here rather than silently
correcting content outside this PR's stated scope.

Verification (branch tc18-533-propagate-canep-i2c-iseled-linep-mdio-adc-master-id,
based on origin/main @ 0bbe7dd, re-confirmed fresh immediately before push):

  • cmake -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=17
    -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DRELAY_BUILD_CLI=ON -G Ninja
    && cmake --build build --parallel: 219/219 targets, 0 errors
    (pre-existing toolchain -Wnonnull notes in unrelated
    test_l2.cpp/test_udp.cpp translation units only, not from this
    change).
  • ctest --test-dir build --output-on-failure -j1: 53/53 suites
    passed (100%), 47.51s.
  • cpp-FuSa v0.18.0 (built from source, matching
    .github/workflows/ci.yml's pin) cpfusa check: 0 errors, 2
    warnings, 1 info — identical before and after this change
    (pre-existing FUSA004/FUSA005/HARA005 findings, unrelated to
    .fusa-reqs.json).
  • cpfusa trace --format json coverage: totalRequirements=376,
    tracedRequirements=376, testedRequirements=376,
    secTestedRequirements=64 — identical before and after (confirmed
    via git stash A/B comparison), consistent with PR docs(fusa): [c-RCP-18-tracker Part 1] propagate tc18_master_id for REQ-WIRE-* #108's own
    stated 376/376/376/64 baseline. Metadata-only change, no coverage
    impact.
  • git diff --stat: .fusa-reqs.json | 83 ++++++++++++++++++++--------
    (62 insertions, 21 deletions) across exactly 21 requirement
    entries (20 newly linked + REQ-ADC-002's pre-existing tc18 field
    corrected and given its tc18_master_id).

Signed-off-by: Matt Jones 47545907+SoundMatt@users.noreply.github.com
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

SoundMatt and others added 2 commits August 19, 2026 12:20
…Q-CANEP-*/REQ-I2C-*/REQ-ISELED-*/REQ-LINEP-*/REQ-MDIO-*/REQ-ADC-*

This batch links 21 of the 32 requirements across REQ-CANEP-* (7),
REQ-I2C-* (5), REQ-ISELED-* (5), REQ-LINEP-* (4), REQ-MDIO-* (5), and
REQ-ADC-* (6) to their TC18 master-catalog clauses (RELAY's
docs/tc18-master-catalog.json), verified directly against TC18.txt
(the line-numbered plaintext extraction) and cpp-RCP's own
include/rcp/{can,i2c,iseled,lin,mdio,adc}.hpp headers and their
tests/test_*.cpp files — not copied from go-RCP's already-merged
equivalent batches, per the task's instruction to verify independently
since cpp-RCP's own wording/implementation choices can differ even
where the underlying TC18 clause is identical.

All six prefixes are the genuine per-endpoint-type TC18 packages (same
role as go-RCP's already-confirmed CAN/I2C/ISELED/LIN/MDIO/ADC
equivalents), not part of cpp-RCP's non-TC18 integration-shell set —
confirmed by reading each header's own doc comment, none of which
carries a TC18-scope disclaimer.

Linked (21):

  REQ-LINEP-001 -> TC18-13.2-002      ep_type=0x06, Table 32 "ep_type values"
  REQ-LINEP-002 -> TC18-13.7.10.3-001 Figure 39 raw "Lin payload" wire region, no PID/checksum/schedule sub-fields
  REQ-LINEP-003 -> TC18-13.7.10.1-001 match-based reply behavior underlying responded/no-responded branching

  REQ-CANEP-001 -> TC18-13.2-002      ep_type=0x0B, Table 32 "ep_type values"
  REQ-CANEP-003 -> TC18-13.7.11.3-004 "Sending remote frames is not supported."
  REQ-CANEP-004 -> TC18-13.7.11.3-002 CAN XL 2054-byte ceiling + segmentation requirement
  REQ-CANEP-005 -> TC18-13.7.11.2-002 Table 56 CAN bit time registers 1/2/3 (Classical/FD/XL)
  REQ-CANEP-006 -> TC18-13.7.11.2-002 Table 56 acceptance/receive filter register fields

  REQ-ISELED-001 -> TC18-13.2-002      ep_type=0x0C, Table 32 "ep_type values"
  REQ-ISELED-002 -> TC18-13.7.12.3-001 Figure 41 request shape (+ Figure 42 response shape cited in-text)
  REQ-ISELED-003 -> TC18-13.7.12.3-004 "A response always contains the 12 bit address and 12 bit data plus the optional 4 bit CRC."
  REQ-ISELED-004 -> TC18-13.7.12.1-002 "single trigger event ... when transmission ... has been completed"

  REQ-MDIO-001 -> TC18-13.2-002       ep_type=0x0D, Table 32 "ep_type values"
  REQ-MDIO-002 -> TC18-13.7.13.3-002  Table 60 mdio_payload width rules per mdio_mode

  REQ-I2C-002 -> TC18-13.7.7.1-003 optional wait-for-bit-sequence request
  REQ-I2C-003 -> TC18-13.7.7.3-001 transparent raw payload incl. address (Figure 30)
  REQ-I2C-004 -> TC18-13.7.7.4-001 optional HW trigger event generation (Table 50's own Event column is blank in the extraction, so specific signal names are this implementation's own)

  REQ-ADC-001 -> TC18-13.7.9.3-003 "A measured value may contain the average of multiple ADC samples..."
  REQ-ADC-002 -> TC18-13.7.9.1-006 averaging-interval + COMBINE_NR_VAL clause (also corrects this entry's PRE-EXISTING tc18 citation, added before this batch: it quoted this exact text but misattributed it to §13.7.9.2 L5040 — verified against TC18.txt, the quote only occurs at §13.7.9.1 L5455-5457)
  REQ-ADC-003 -> TC18-13.7.9.1-010 "The ADC only samples the input, when a request is executed..."
  REQ-ADC-004 -> TC18-13.7.9.1-002 PWM-triggered ADC read concept

Deliberately skipped (11), with reasoning:

  REQ-I2C-001    i2c_mode's coarse hs-bit decode is an explicitly
                 documented open item (header comment: "pending a
                 future spec errata pass") — no single TC18 clause
                 cleanly covers an intentionally-unresolved ambiguity.
  REQ-I2C-005    boilerplate error-category/non-empty-message test,
                 no distinct TC18 clause.
  REQ-CANEP-002  11-bit/29-bit CAN identifier numeric range boundaries
                 (0x7FF / 0x1FFFFFFF) are standard CAN-protocol facts;
                 TC18's own CAN section text only states "In case the
                 CAN ID is 11bits, then it shall be right aligned..."
                 (right-alignment, not range validation) and never
                 states the 29-bit extended range numerically anywhere
                 in the extraction — grepped TC18.txt to confirm no
                 "29-bit"/"29 bit"/"0x1FFFFFFF" text exists.
  REQ-CANEP-007  Combines two things, neither independently citable:
                 (a) "CAN has no TriggerRegistry" is a structural
                 absence (TC18's CAN section genuinely has no trigger-
                 signal subsection, unlike I2C/ADC/UART/PWM), which
                 cannot be supported by a positive spec quote; (b) the
                 CanErrc-category half is the same boilerplate pattern
                 skipped everywhere else in this batch.
  REQ-ISELED-005 boilerplate error-category test, no distinct TC18
                 clause.
  REQ-MDIO-003   register write-then-read round-trip and "unwritten
                 register reads 0" are this implementation's own
                 internal-fidelity choices; TC18's MDIO section has no
                 register-persistence-semantics text to cite.
  REQ-MDIO-004   (mdio_mode, mdio_address) register-space distinctness
                 is implementation-internal; MDIO's TC18 section
                 (13.7.13.1-.3) has no trigger-signal subsection at
                 all (unlike I2C/ADC/UART/PWM), so "notify
                 TransferComplete on every request" also has no TC18
                 basis to cite.
  REQ-ADC-005    AdcErrc::no_signal is explicitly documented in
                 adc.hpp's own header comment as "an internal
                 condition... not a TC18 error code" (TC18's Table 27
                 error-code list has no ADC-specific no-signal entry)
                 — the missing-triggered-capture behavior this
                 requirement tests is this implementation's own choice,
                 not a spec clause.
  REQ-ADC-006    boilerplate error-category test, no distinct TC18
                 clause.
  REQ-LINEP-004  boilerplate error-category test, no distinct TC18
                 clause.

Citation correction found: REQ-ADC-002's tc18 field (added before this
batch, likely from an earlier ADC-focused pass — this batch found it
already present but WITHOUT a tc18_master_id) cited "§13.7.9.2 ...
TC18.txt L5040" for the "an implementation may decide to fix" quote.
Verified against TC18.txt directly: that quote exists exactly once, at
§13.7.9.1 L5455-5457, not §13.7.9.2, and not at L5040. Corrected in
this commit alongside adding the missing tc18_master_id.

Drift finding (not corrected, out of this pass's metadata-only scope):
REQ-ISELED-004's title/text still describe a NativeCrcError trigger
signal and IseledErrc::native_crc_mismatch error that
include/rcp/iseled.hpp's own header comment documents were removed by
the issue #71/cpp-RCP-02 wire-format fix (the invented CRC-8 was
removed because this repo has no verified copy of the real ISELED CRC
algorithm). tests/test_iseled.cpp's REQ-ISELED-004 case now only
exercises the single surviving TransferComplete signal. This entry is
still linkable (TC18-13.7.12.1-002, "single trigger event ... when
transmission ... has been completed" matches the current, narrower
tested behavior), but its title/text predate that fix and should be
updated by a future pass; flagged here rather than silently
correcting content outside this PR's stated scope.

Verification (branch tc18-533-propagate-canep-i2c-iseled-linep-mdio-adc-master-id,
based on origin/main @ 0bbe7dd, re-confirmed fresh immediately before push):
  - cmake -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=17
    -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DRELAY_BUILD_CLI=ON -G Ninja
    && cmake --build build --parallel: 219/219 targets, 0 errors
    (pre-existing toolchain -Wnonnull notes in unrelated
    test_l2.cpp/test_udp.cpp translation units only, not from this
    change).
  - ctest --test-dir build --output-on-failure -j1: 53/53 suites
    passed (100%), 47.51s.
  - cpp-FuSa v0.18.0 (built from source, matching
    .github/workflows/ci.yml's pin) `cpfusa check`: 0 errors, 2
    warnings, 1 info — identical before and after this change
    (pre-existing FUSA004/FUSA005/HARA005 findings, unrelated to
    .fusa-reqs.json).
  - `cpfusa trace --format json` coverage: totalRequirements=376,
    tracedRequirements=376, testedRequirements=376,
    secTestedRequirements=64 — identical before and after (confirmed
    via git stash A/B comparison), consistent with PR #108's own
    stated 376/376/376/64 baseline. Metadata-only change, no coverage
    impact.
  - git diff --stat: .fusa-reqs.json | 83 ++++++++++++++++++++--------
    (62 insertions, 21 deletions) across exactly 21 requirement
    entries (20 newly linked + REQ-ADC-002's pre-existing tc18 field
    corrected and given its tc18_master_id).

Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Independent review found the original batch linked REQ-ISELED-004 --
whose own text is entirely about NativeCrcError/native_crc_mismatch CRC
verification -- to TC18-13.7.12.1-002, the *adjacent* trigger-event
clause ('The ISELED endpoint creates a single trigger event...'), not
the CRC clause the requirement is actually about.

TC18-13.7.12.1-001 ('The optional CRC generation as specified in the
ISLED standard can be enabled. If so, the CRC will be generated and
attached to the write messages to the ISELED network. For read data
accordingly the CRC will be also calculated and checked.', TC18.txt
L5910-5912) is the correct match -- verified directly against TC18.txt.

The original batch's own NOTE about this entry's stale title/text
(referencing a NativeCrcError signal issue #71/cpp-RCP-02 already
removed) is preserved, since that finding is independently correct and
still out of scope for this metadata-only pass.

Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@SoundMatt

Copy link
Copy Markdown
Owner Author

Independent review follow-up: found and fixed one citation-accuracy defect. REQ-ISELED-004 (whose own text is entirely about NativeCrcError/native_crc_mismatch CRC verification) was linked to TC18-13.7.12.1-002, the adjacent trigger-event clause ("The ISELED endpoint creates a single trigger event..."), not the CRC-related clause the requirement is actually about. Corrected to TC18-13.7.12.1-001 ("The optional CRC generation as specified in the ISLED standard can be enabled. If so, the CRC will be generated and attached to the write messages to the ISELED network. For read data accordingly the CRC will be also calculated and checked.", TC18.txt L5910-5912) — verified directly against TC18.txt. The original batch's own flagged finding (this entry's stale title/text referencing a removed NativeCrcError signal, issue #71/cpp-RCP-02) is preserved as still correct and out of scope here.

Spot-checked 7 other citations directly against TC18.txt (I2C-002/003/004, ADC-002 correction, all 4 §13.2 Table 32 ep_type entries) — all verified byte-exact. Merge-base confirmed fresh against origin/main both before I started and just now before push (no rebase needed this time).

Re-verified after the fix: cmake+ninja build 219/219 targets clean, ctest 53/53 passing, cpfusa v0.18.0 check 0 errors (2 warnings/1 info, matches baseline), trace coverage unchanged at 376/376/376/64. Watching CI, will merge once green.

@SoundMatt
SoundMatt merged commit 1d4199f into main Aug 19, 2026
41 of 43 checks passed
@SoundMatt
SoundMatt deleted the tc18-533-propagate-canep-i2c-iseled-linep-mdio-adc-master-id branch August 19, 2026 20:23
SoundMatt added a commit that referenced this pull request Aug 19, 2026
…Q-CAN-*/REQ-GPIO-*/REQ-PWM-*/REQ-SPI-*/REQ-UART-*/REQ-WAKEUP-* (#110)

Scope note: REQ-CAN-* does not exist in cpp-RCP's .fusa-reqs.json. Unlike
go-RCP (where a REQ-CAN-* client-ergonomics wrapper package `canbr` still
exists alongside the real endpoint's REQ-CANEP-*), cpp-RCP's canbr.hpp/
linbr.hpp bridge stubs — which historically used REQ-CAN-001..004/
REQ-LIN-001..004 (ROADMAP.md, "44 requirement entries that back the
deleted packages") — were already DEPRECATEd and deleted outright in a
prior milestone, and their requirement entries pruned from
.fusa-reqs.json entirely (README.md: "CAN and LIN are native TC18
Endpoint types ... not bridge targets, so this package carries no
canbr.hpp/linbr.hpp"). REQ-CANEP-* (the real CAN endpoint) was already
linked in PR #109. So there is nothing to link under REQ-CAN-* here: 0
entries exist under that prefix.

This batch instead covers cpp-RCP's remaining per-endpoint-type packages:
REQ-GPIO-* (9), REQ-PWM-* (7), REQ-SPI-* (5), REQ-UART-* (7),
REQ-WAKEUP-* (5) — 33 entries in scope, 24 linked, 9 deliberately skipped.

Section numbers verified directly against TC18.txt (not assumed from
memory or from go-RCP's citations, which use a different section
layout for at least PWM):
  - GPIO: §13.7.4 (NOT §13.7.3 as originally guessed — §13.7.3 is SPI)
  - SPI: §13.7.3
  - PWM_OUT: §13.7.5, PWM_IN: §13.7.6
  - UART: §13.7.8
  - WAKEUP: §13.7.2
  - Shared evt-field semantics table (GPIO/PWM_OUT write combinators,
    saturation, ep_type enum, compound-wait): §13.2/§13.5/§13.5.1

== Per-prefix verdict ==

REQ-CAN-*: 0 entries exist (see scope note above). N/A.

REQ-GPIO-* (9 total): 6 linked, 3 skipped.
  Linked: 001, 002, 003, 004, 005, 009.
  Skipped:
    - 006 "GPIO functional config block wiring" — the file's own header
      comment explicitly disclaims that "the concrete pin-direction bit
      convention, functional-config layout... chosen in this file are
      this implementation's own." TC18's actual GPIO functional-config
      register map (Table 44, §13.7.4.2) has no pin-direction or
      per-pin edge-enable fields at all (only debounce/clock/enable/
      status) — linking to Table 44 would be a section-proximity match,
      not a content match, the exact mistake PR #109's review caught.
    - 007 "GpioEndpoint request-dispatch pattern" — an internal API
      orchestration claim (apply write + evaluate triggers + report
      bitmask "in one call"); its constituent behaviors are already
      individually covered by REQ-GPIO-002/003/004/005's own citations.
      Same shape as REQ-MDIO-003 ("MDIO register write-then-read
      round-trip"), left unlinked in PR #109 for the same reason.
    - 008 "GpioEndpoint error propagation and GpioErrc category" —
      implementation-only error-category plumbing, consistent with
      every other endpoint's *Errc entries (REQ-SPI-005, REQ-I2C-005,
      REQ-ADC-006, REQ-MDIO-005, REQ-UART-007, REQ-PWM-007,
      REQ-WAKEUP-005 below) being left unlinked throughout this and the
      prior batch.

REQ-PWM-* (7 total): 6 linked, 1 skipped.
  Linked: 001, 002 (citation corrected), 003 (citation corrected), 004,
  005, 006 (citation corrected).
  Skipped: 007 (PwmErrc error category — implementation-only, see above).

REQ-SPI-* (5 total): 4 linked, 1 skipped.
  Linked: 001 (citation corrected), 002, 003, 004.
  Skipped: 005 (SpiErrc error category — implementation-only).

REQ-UART-* (7 total): 4 linked, 3 skipped.
  Linked: 001, 002, 003, 005.
  Skipped:
    - 004 "UART payload-less pure read requests" — TC18 §13.7.8.1 only
      says a UART read *carrying* a byte_msg_payload is rejected
      (UNKNOWN_CMD); it does not define a distinct non-blocking
      "pure read" request kind for UART the way §13.7.4.3 explicitly
      names one for GPIO. handle_pure_read's own doc comment concedes
      this is this implementation's own API convenience ("no read_size
      is carried at all, so there is nothing to wait on"), not a
      TC18-named UART behavior distinct from what REQ-UART-002/003
      already cover.
    - 006 "UART RX FIFO / read_size single-AVTPDU accepted limitation"
      — this requirement documents a deliberate NON-conformance: TC18
      §13.7.8.1 mandates fragmenting the response when read_size
      exceeds uart_rx_fifo_size (TC18-13.7.8.1-004); this milestone's
      accepted limitation (ROADMAP.md milestone 52, fragmentation
      no-go) instead rejects such requests outright. Linking it would
      misrepresent a documented gap as coverage.
    - 007 (UartErrc error category — implementation-only).

REQ-WAKEUP-* (5 total): 4 linked, 1 skipped.
  Linked: 001, 002, 003, 004.
  Skipped: 005 (WakeupErrc error category — implementation-only).

== Full id -> master-catalog-id mapping (24 entries) ==

REQ-GPIO-001 -> TC18-13.7.4.1-005 "GPIO request length validation": TC18
  requires rejecting any GPIO request not exactly 4 bytes
  (INVALID_PARAMETER); matches kGpioPayloadLen=4 / short_buffer.
REQ-GPIO-002 -> TC18-13.5-001 "EP-specific usage of evt-field": Table 33's
  GPIO/PWM_OUT row defines evt[2:0]=000b/001b/010b/011b as
  Replace/OR/AND/XOR against current interface status; matches
  apply_bitmask_write's Replace/Or/And/Xor.
REQ-GPIO-003 -> TC18-13.5-003 "Saturation arithmetic for GPIO/PWM_OUT
  add/subtract": "neither overflows nor wrap-arounds... saturated at
  0x0000/0xFFFF" — matches the saturating (not wrapping) Add/Subtract
  rule directly.
REQ-GPIO-004 -> TC18-13.5-001: same Table 33 GPIO/PWM_OUT row,
  evt[2:0]=100b (reserved/rejected) and 111b (reconfigure — endpoint
  config change, not a value written to the interface); matches
  Reserved-rejected / Reconfigure-retargets-directions split.
REQ-GPIO-005 -> TC18-13.7.4.1-011 "Optional GPIO edge/change trigger
  generation": "generates triggers for all its mapped IO-pins on the
  change, falling and rising edge" — matches per-pin Change/Rising/
  Falling signal evaluation.
REQ-GPIO-009 -> TC18-13.7.4.3-004 "Write to input pin is ignored":
  "A write request to an input pin is ignored for this input pin" —
  direct match, quote already correct pre-existing; only the line
  number and master_id were added.

REQ-PWM-001 -> TC18-13.7.5.3-001 "pwmo request format": "The PWM_out
  request and response contain two values in the payload. The active
  time... as well as the period" — matches the shared two-field
  PwmValue{period, active_duration} shape.
REQ-PWM-002 -> TC18-13.5-001: Table 33 GPIO/PWM_OUT row, evt[2:0]=000b
  ("byte_msg_payload is presented at the interface") — matches Replace
  applying period/active_duration directly. CITATION CORRECTED (was
  "Table 30", which is TC18's actual "Error codes in responses" table,
  not the evt-field table — the real table is Table 33).
REQ-PWM-003 -> TC18-13.5-003: same saturation clause as REQ-GPIO-003,
  applied per-field to PwmValue's uint16_t range. CITATION CORRECTED
  (was "Table 30" + "TC18.txt L3694-3714", which points at an unrelated
  sequencer request-state-machine passage, not Table 33/the saturation
  note at all).
REQ-PWM-004 -> TC18-13.5-001: same Table 33 row, evt[2:0]=100b/111b, as
  REQ-GPIO-004 — matches Reserved-rejected / Reconfigure-unsupported
  (PWM_OUT has no reconfigure target of its own besides its functional
  config registers).
REQ-PWM-005 -> TC18-13.7.6.1-001 "PWM_IN max-period exceeded /
  source-loss error notification": "if... the external PWM source
  stops, the PWM_IN endpoint will detect this and... notify the RC
  Client with an error response message" (error code PWM_IN_NO_SIGNAL,
  Table 30) — matches no_signal before first measurement / after
  clear_signal().
REQ-PWM-006 -> TC18-13.7.6.1-002 "pwmi trigger outputs": Table 47 defines
  exactly two PWM_IN trigger signals (0=rising edge, 1=falling edge) —
  matches RisingEdge/FallingEdge notification. CITATION CORRECTED (was
  "§13.7.5.1 Table 44" — §13.7.5.1 is PWM_OUT's pin-config section and
  Table 44 is GPIO's functional-config register map; the real anchor is
  §13.7.6.1 Table 47, the actual "pwmi trigger outputs" table).

REQ-SPI-001 -> TC18-13.7.3.2-006 "Parallel SPI: up to 6 CS
  configurations, selected via evt[2:0]": "up to 6 CS signals may be
  handled by the SPI endpoint... the SPI bus functional configuration
  supports up to 6 different configurations in parallel... determined
  by evt[2:0]" — matches kMaxChannels=6, evt[2:0] 0-5 valid / 6,7
  rejected. CITATION CORRECTED (was "§13.7.3.1" quoting "up to 6
  pre-configurable sets of SPI configurations" at L4192 — TC18.txt
  L4192 is CRC/Safe-command-mode text, unrelated; and §13.7.3.1's real
  text says "up to 16" pre-configurable sets selected via byte_bus_id,
  not evt[2:0] — a known, spec-internal, editorially-flagged
  inconsistency between the "16" figure in §13.7.3.1 and the "6" figure
  in §13.7.3.2, per master-catalog entry TC18-13.7.3.1-002's own notes.
  cpp-RCP's kMaxChannels=6 + evt[2:0] selection matches §13.7.3.2's "6"
  clause, not §13.7.3.1's "16" one).
REQ-SPI-002 -> TC18-13.5.1-001 "Compound-wait byte-length mismatch
  handling": "the interface status shall be capped to the length of
  the byte message payload. For SPI this means that e.g. only the
  first four out of 20 received bytes will be checked..." — exact
  match, including cpp-RCP's own kCompoundWaitCompareLen=4 /
  kMaxStatusBytes=20 constants mirroring TC18's own worked example.
REQ-SPI-003 -> TC18-13.7.3.1-003 "Client byte-send request to SPI
  endpoint": "The RC Client can request the SPI endpoint to send one or
  more bytes that are delivered as byte_msg_payload..." — matches the
  raw PICO-out/POCI-in transfer request/response mechanism.
REQ-SPI-004 -> TC18-13.7.3.1-007 "SPI trigger outputs mapping": Table 41
  defines signal 0 = SPI execution done, (2+2n) = CSn asserted,
  (3+2n) = CSn de-asserted — matches CsAssert/TransferComplete/
  CsDeassert and the per-(channel,signal) distinct SignalId scheme (the
  specific notification *order* is this implementation's own choice,
  not spec-mandated, consistent with this file's own disclaimer).

REQ-UART-001 -> TC18-13.7.8.1-001 "UART EP dual independent TX/RX
  request storages": "these two processes are independent from each
  other, thus the UART EP has two EP request storages" — direct match.
REQ-UART-002 -> TC18-13.7.8.1-002 "UART RX FIFO buffering and overflow
  flagging": "the UART EP shifts the received data into a
  fifo-rx-buffer... emptied by read requests. Overflow is flagged..."
  — direct match.
REQ-UART-003 -> TC18-13.7.8.1-004 "UART read request trigger conditions
  and fragmentation sizing": "A read request will be started as soon
  as the fifo-rx-buffer is filled with as many bytes as requested in
  the read_size or when the uart_timeout has expired" — matches the
  read-completion rule. (Citation deliberately quotes only the
  read_size/timeout portion, not the fragmentation sentence that
  follows it in the same TC18 passage — this implementation's
  read_size_exceeds_bound rejection is a documented divergence from
  that fragmentation behavior, per REQ-UART-006, not an implementation
  of it.)
REQ-UART-005 -> TC18-13.7.8.3-004 "UART EP ignores trailing
  non-integer-multiple bits when transmitting": "In case uart_nr_bits
  is not a multiple integer of 8... the EP ignores the last up to
  'uart_nr_bits - 1' bits..." — matches the sub-octet
  mask-to-low-bits/zero-pad-high-bits packing rule.

REQ-WAKEUP-001 -> TC18-13.2-002 "ep_type enumerated values": Table 32
  lists 0x01 = WakeUp — matches kEndpointTypeWakeup=0x01. Same
  master_id as REQ-CANEP-001/REQ-MDIO-001 from PR #109 (same table,
  different row). Deliberately NOT linked to TC18-13.7.2.1-001 ("WakeUp
  endpoint fixed at EP nr 1") — that clause is about EP_Nr (instance
  position), a different field from ep_type (the type-code value this
  requirement actually tests); confirmed by reading endpoint.hpp's own
  kEndpointType* constant block, which is exactly Table 32's ep_type
  enumeration.
REQ-WAKEUP-002 -> TC18-13.7.2.3-004 "SleepCMD fixed code value":
  "SleepCMD is coded as 0xA5." — direct, exact match.
REQ-WAKEUP-003 -> TC18-13.7.2.2-002 "WakeUp functional configuration
  register map": Table 39's wup_status register — "Indication of
  wake-up source, writing '1' clears the flag. Each bit represents a
  wake-up source" — matches record_wake_source_event setting a bit /
  clear_wake_source_pins() resetting the mask.
REQ-WAKEUP-004 -> TC18-13.7.2.1-002 "Repetitive wake-up messages after
  reconnection": "After establishing a network connection, the WakeUp
  endpoint sends repetitive messages. The timing interval is
  configurable (flush_time)." — matches the repeating WakeUp-message
  handshake for hot-start-from-Sleep.

== Citation corrections found (5) ==

1. REQ-SPI-001: wrong section (§13.7.3.1 instead of §13.7.3.2), wrong
   quote (misattributed the "6" figure to §13.7.3.1's text, which
   actually says "16"), and wrong line number (L4192 is CRC/Safe-mode
   text, not SPI channel-count text at all).
2. REQ-PWM-002: "Table 30" corrected to "Table 33" (Table 30 in TC18 is
   "Error codes in responses"; the evt-field table is Table 33).
3. REQ-PWM-003: same Table 30->33 correction, plus the line range
   L3694-3714 (sequencer request-state-machine text) corrected to the
   real Table 33 saturation-note location, L4094-4119.
4. REQ-PWM-006: "§13.7.5.1 Table 44" corrected to "§13.7.6.1 Table 47"
   (§13.7.5.1/Table 44 are PWM_OUT/GPIO material; PWM_IN's actual
   trigger-outputs table is §13.7.6.1 Table 47).
5. REQ-GPIO-009: quote content was already accurate; only the missing
   "TC18.txt L####" line-number suffix was added for consistency with
   every other linked entry's citation format.

Note: REQ-PWM-002/003's own pre-existing `text` fields also say
"§13.5 Table 30" — left untouched per field-preservation (only `tc18`/
`tc18_master_id` are new/corrected fields in this batch); the `text`
field's wording is a separate, smaller pre-existing inaccuracy not in
this batch's scope to rewrite.

== Deliberately-untouched entries (9) ==
REQ-GPIO-006, REQ-GPIO-007, REQ-GPIO-008, REQ-PWM-007, REQ-SPI-005,
REQ-UART-004, REQ-UART-006, REQ-UART-007, REQ-WAKEUP-005 — reasoning
per-entry above (per-prefix verdict section).

== Verification ==
- cmake -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=17
  -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DRELAY_BUILD_CLI=ON -G Ninja &&
  cmake --build build --parallel: clean rebuild, 0 errors.
- ctest --test-dir build --output-on-failure -j1: 53/53 passing
  (matches PR #109 baseline).
- cpfusa v0.18.0 check: 0 errors, 2 warnings, 1 info (unchanged from
  baseline).
- cpfusa v0.18.0 trace --format json: 376 total/376 traced/376 tested/
  64 secTested (identical before and after — only citation metadata
  fields were added, no requirement entries or test annotations
  changed).
- git diff --stat: 1 file changed (.fusa-reqs.json only), 67
  insertions(+), 24 deletions(-) — 24 tc18_master_id fields added, 24
  tc18 fields present after (19 new + 5 corrected in place).

Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
SoundMatt added a commit that referenced this pull request Aug 19, 2026
…Q-E2E-*/REQ-REGMAP-*/REQ-SEQ-* (#112)

Links 35 of 41 REQ-E2E-*/REQ-REGMAP-*/REQ-SEQ-* entries in .fusa-reqs.json
to the RELAY tc18-master-catalog.json (447 entries), adding "tc18" and
"tc18_master_id" fields. cpp-RCP moves from 78/376 to 113/376 linked.

Scope verification (all three packages carry an explicit TC18-scope doc
comment citing "extraction" section numbers — none of the excluded
"integration shell" naming patterns from #109/#110 apply here):

- rcp/e2e.hpp (REQ-E2E-*): TC18's end-to-end CRC integrity mechanism
  (crc32/coverage_buffer/verify_crc) plus the per-request-stream
  watchdog/safe-state primitives, riding on rcp/acf.hpp, rcp/avtp.hpp,
  rcp/regmap.hpp and rcp/request.hpp. Confirms the task hypothesis
  (CRC/E2E protection, cross-cutting into §12.7.7 and §13.6).
- rcp/regmap.hpp (REQ-REGMAP-*): the RC Server register-map data model
  and EP0 pseudo-endpoint (generic/functional config split, root-client
  arbitration, whole-map read/write). Confirms the §12.6/§12.7.x
  hypothesis, and additionally reaches into §12.3.1.x (lifecycle-gated
  locking) and §13.1/§13.2/§13.7.1.2 (EP0/ROOT_CLIENT semantics).
- rcp/request.hpp (REQ-SEQ-*, module renamed from rcp/sequencer.hpp per
  RELAY spec §13.7.2): conditional-request taxonomy (compound,
  compound-wait, triggered, chained, timed) AND sequencer-state
  primitives, both living in one file/prefix. Confirms the §12.10
  hypothesis but the taxonomy half draws far more heavily on §11.2.2/
  §11.2.2.x/§11.2.3.x (conditional-request wire format, cancellation)
  and §12.9.2/§12.9.3 (priority/lifecycle) than on §12.10 itself, which
  in this file is used only for REQ-SEQ-004's default/advance rule.

Per-prefix verdict: E2E 11/14 linked, REGMAP 13/15 linked, SEQ 11/12
linked — all three fully TC18-scoped (no entries excluded as
non-TC18 "integration shell"); the 6 gaps are cases where cpp-RCP's own
field/enum granularity goes beyond what TC18's text literally defines,
not scope exclusions.

== REQ-E2E-* (11/14 linked) ==

REQ-E2E-001 -> TC18-13.6-003 (CRC32P4 polynomial parameters, Table 34):
crc32's poly/init/refin/refout/xorout constants are a verbatim match for
Table 34's 0xF4ACFB13/0xFFFFFFFF/TRUE/TRUE/0xFFFFFFFF.

REQ-E2E-002 -> TC18-13.6-005 (ACF_GBB under NTSCF header CRC field
layout, Figure 21): coverage_buffer's ACF_GBB 16-byte Message-Info form
(message_timestamp spliced between the two header quadlets) is exactly
Figure 21's byte layout; Figure 20 (ACF_ABB, TC18-13.6-004) covers the
other half of the same requirement's text but only one master_id fits
the field, so the more heavily-described GBB case was chosen as primary.

REQ-E2E-003 -> TC18-13.6-006 (acf_msg_length accounting for appended
CRC): "adding the CRC to the byte_msg_payload increases the
acf_msg_length by 1" is a direct match for apply_acf_length_adjustment's
+1-quadlet rule; the companion +4-octet control_data_length adjustment
is this implementation's own derived consequence for wrapping headers,
not separately spelled out in TC18 text.

REQ-E2E-004 -> TC18-13.6-001 (Safe command mode CRC mismatch handling):
"the request is not executed, and an error response is generated with
error code: CRC_ERROR" is a verbatim match for verify_crc's
crc_error/CRC_ERROR contract.

REQ-E2E-005 -> SKIPPED. crc_required checks three independently-toggled
booleans keyed by MessageRole (Request/Ack/Response) living in
EndpointGenericConfig; TC18's only literal CRC-enable bits are
per-request-STREAM (rx_enforce_crc, §12.7.7 Table 24) and per-BBID
(CRC_required, §12.7.8 Table 26) — neither is keyed by message role.
implemented_options_bit's kOptSafetyRequests also has no literal TC18
bit position: svr_implemented_options (§12.7.5 Table 20) documents only
bits a-e (compound&wait/trigger/chained/timed/enhanced-cancellation) of
its 8-bit "abcdefgh" pattern; f/g/h are undocumented. Read both Table 20
and Table 26 directly before concluding neither's granularity matches —
left unlinked rather than forcing a section-only match.

REQ-E2E-006 -> TC18-12.7.7-001 (Request stream configuration register
map, Table 24): rx_enforce_crc's documented 0/1 semantics ("stream is
not blocked, when CRC check at EP fails" / "stream is blocked until
released ... and Safe state will be entered") is exactly
RxStreamGuard's drop-vs-latch rule gated on rx_enforce_e2e.

REQ-E2E-007 -> TC18-12.7.7-001 (same Table 24): rx_enforce_sequence's
0/1 semantics ("not blocked upon out of order reception" / "blocked
... and Safe state will be entered") is exactly RxSequenceGuard's
accept-vs-sequence_violation rule gated on rx_enforce_seq.

REQ-E2E-008 -> TC18-12.7.7-001 (same Table 24, reusing REQ-WDG-001's
already-merged citation for the identical field pair):
rx_wd_timeout_intervall + rx_enforce_watchdog's documented semantics
match RxWatchdog::overflowed's rx_wd_enable/rx_wd_timeout_interval gate.

REQ-E2E-009 -> TC18-11.2.2-001 (Safety-request retention on MSB-set
condition identifiers): "the request is treated as a safety request and
will not be deleted when the EP needs to go to safe state" is the
general principle apply_watchdog_overflow implements via
RequestLedger::cancel_all(true) (purge is_safety=false, retain
is_safety=true). The specific *mechanism* reused
(cancel_all/non_safestate_only) is separately TC18-cited for
REQ-SEQ-012; TC18's own text does not itself connect watchdog overflow
to that named cancellation operation, so the general retention
principle is the better-grounded citation here.

REQ-E2E-010 -> TC18-11.2.2-001 (same clause): apply_queue_overflow
implements "the same purge-normal/retain-safety rule via a distinct
trigger" per its own title — same underlying TC18 principle, different
RequestStreamConfig gate (rx_ovrflw_safestate_enable vs.
rx_wd_safestate_enable).

REQ-E2E-011 -> TC18-12.7.7-001 (Request stream configuration, Table 24
+ prose). CITATION CORRECTION: the pre-existing tc18 field on this entry
quoted TC18.txt L2935, but L2935 is mid-Table-20 (svr_implemented_options
bit descriptions) and does not contain the quoted text at all — grep
confirms "a safe state may be enforced. The safe state to enter can be
chosen via the Safety_Measure parameter" appears exactly once in
TC18.txt, at L3300 (§12.7.7's paragraph following Table 24). Fixed the
line number to L3300 and added the missing tc18_master_id (rx_safestate_
seqencer/rx_safe_sequencer_state are Table 24 fields; the Safety_Measure
parameter is this same paragraph, matching endpoint_in_configured_safe_
state's RxSafetyMeasure::ForceHighImpedance/RunSafeSequencer strategies).

REQ-E2E-012 -> TC18-11.2.2-001 (same MSB-safety clause as 009/010):
may_execute_now's execution-eligibility gate for is_safety=true records
is this implementation's behavioral extension of the same "treated as a
safety request" principle (TC18 states retention; this requirement adds
the complementary "gated execution once eligible" behavior on the same
underlying is_safety concept — no separate TC18 clause describes
execution-gating specifically, so the root MSB-safety clause is cited).

REQ-E2E-013 -> SKIPPED. RxWatchdog::should_emit_info_notification's
rx_wd_info_enable field and "repeating info notification while latched"
behavior have no TC18 textual basis found — grepped TC18.txt for
"notification"/"repeating"/"periodic" near the watchdog sections; no
match. This is cpp-RCP's own v2.6.0 field-set extension per
regmap.hpp's own disclaimer ("Concrete field widths ... are this
implementation's own encoding of that behavior").

REQ-E2E-014 -> SKIPPED, following the established cross-batch precedent
(confirmed by grepping the file: every other "-Errc is a distinct
category with non-empty ... messages" requirement in this repo —
REQ-PWR-014, REQ-REGMAP-014, REQ-DISC-008, REQ-SPI-005, REQ-I2C-005,
REQ-UART-007, REQ-ADC-006, REQ-PWM-007, REQ-SEQ-009, REQ-LINEP-004,
REQ-CANEP-007, REQ-ISELED-005, REQ-MDIO-005, REQ-WAKEUP-005 — is
unlinked). This is a generic C++ std::error_category implementation
pattern, not itself a TC18 clause, even where the enum's individual
values happen to reuse TC18 error-code names.

== REQ-REGMAP-* (13/15 linked) ==

REQ-REGMAP-001 -> TC18-13.2-001 (ep_generic_config register map):
the generic-vs-functional split is §13.2's own title framing
("Generic part of endpoint register map (owned by the RC Server)"),
contrasted with "EP_functional configuration" used throughout §13.1/
§13.7. The specific field list in the requirement's text (HW pin
indices, queue sizes) doesn't literally match Table 31's own field
list (ep_type/ep_used/ep_delay_time/...) — this implementation chose
its own contents for the generic block; the structural split itself is
what's TC18-grounded.

REQ-REGMAP-002 -> TC18-12.3.1.1-004 (EP0 full register-map access in
HW_UNCONFIGURED): "Via EP0 the entire register map (i.e. all endpoints)
can be accessed (read and write access)" matches read_whole_map's
unrestricted-read contract. Note: TC18 states this specifically for
HW_UNCONFIGURED state; cpp-RCP generalizes it to be state-independent.
Read all three lifecycle-state subsections (§12.3.1.1-.3) directly to
confirm nothing elsewhere restricts reads at other states (only writes
are gated by W*/W markers) before treating this as a defensible
generalization rather than a mismatch.

REQ-REGMAP-003 -> TC18-13.7.1.2-002 (svr_root_client_index write-access
scope): "Write requests to EP0 via all other streams are limited to
EP0 and not beyond (i.e. other EPs)" is the direct textual basis for
write_whole_map's unauthorized_access-unless-root-client rule.

REQ-REGMAP-004 -> TC18-13.7.1.2-002 (same field): "The svr_root_client_
index is an index that selects the request stream which is in
HW_CONFIGURED still allowed to access all registers" is the field
claim_root_client operates on. Note: TC18 describes this as a plain
register write, not a claim/reject/release transaction protocol —
the request_rejected-on-distinct-claimant / no-op-on-self-reclaim /
release-then-reclaim state machine is this implementation's own
encoding of "how a write to this field gets validated," not literal
TC18 text.

REQ-REGMAP-005 -> TC18-13.1-004 (ROOT_CLIENT-exclusive write access to
server config): matches verbatim — "For other RC Clients than the
ROOT_CLIENT write access is only given to EP_functional configuration
of endpoints which are allocated to the RC Client" is exactly
check_write_access's FUNCTIONAL-block-only rule for non-root clients
(the requirement's own text already cited TC18 §13.1/§13.2 by number;
confirmed §13.1's own MUST clause is the better single anchor for the
write-restriction assertion itself).

REQ-REGMAP-006 -> TC18-12.3.1.2-001 (HW config locked in HW_CONFIGURED):
"access to the HW configuration ... shall have been concluded and as
such all access to the HW_config and EP_generic_config are locked"
directly grounds generic_config_locked's LOCKED_MEM_ACCESS behavior.
Note: TC18 does not describe a symmetric, independently-settable
"functional_config_locked" flag with the same "locked" semantics —
§12.3.1.3 (RCP_CONFIGURED) actually leaves functional config *writable*
via specific stream/root-client paths rather than locking it the same
way. The second half of this requirement (functional_config_locked) is
this implementation's own extension into a second independently-lockable
block; only the generic-config half has a clean 1:1 TC18 match.

REQ-REGMAP-007 -> TC18-12.7.5-001 (RC Server register map, static/
general part, Table 20): direct match — magic/version/vendor_id/
device_id/ep_count and the *_ptr/*_capacity TablePointer fields for
each sub-table are exactly Table 20's own field list.

REQ-REGMAP-008 -> TC18-12.7.6-003 (HW_config pin-mapping table layout,
Table 21): hw_pin_map's HwPinMapEntry(pin_id, function) is this
implementation's simplified encoding of Table 21's per-pin
hw_ep_nr/hw_ep_pin_nr/hw_pin_type triplet.

REQ-REGMAP-009 -> TC18-12.7.7-001 (Request stream configuration,
Table 24): direct match for the whole v2.6.0 watchdog/safe-state field
set (rx_wd_timeout_interval~rx_wd_timeout_intervall,
rx_enforce_e2e~rx_enforce_crc, rx_enforce_seq~rx_enforce_sequence,
rx_safestate_sequencer~rx_safestate_seqencer,
rx_safe_sequencer_state~rx_safe_sequencer_state verbatim). The
rx_wd_safestate_enable/rx_wd_info_enable/rx_seq_safestate_enable/
rx_ovrflw_safestate_enable booleans are this implementation's own
decomposition of Table 24's combined enforce-bit + "and Safe state
will be entered" semantics into separate enable/safestate-enable pairs
— same "own encoding" pattern flagged in e2e.hpp's header comment.

REQ-REGMAP-010 -> TC18-12.7.8-006 (Ascending order of Request_Stream_
Index/BBID entries): "This has to be ensured by the instance that is
sending the configuration to this table" is a verbatim match for
ep_id_mapping's explicit non-re-sorting, non-re-deriving,
insertion-order-preserving contract (the server deliberately does NOT
enforce the ordering TC18 assigns to the client).

REQ-REGMAP-011 -> TC18-12.7.9-007 (Responder QUEUE_config register map,
Table 27): response_queue_size/ack_queue_size are this implementation's
two named instances of Table 27's generic per-queue "queue_size" field,
applied once each to the response queue and the acknowledge queue per
§12.7.9's own prose ("For each response stream or acknowledge stream
the RC Server needs to reserve a transmit queue ... size is given by
... queue_size").

REQ-REGMAP-012 -> TC18-12.7.10-004 (SEQUENCER_config register map,
Table 28): "Seq_state (8bit, current state, default 1 ...)" is a direct
match for sequencer_states' one-persistent-8-bit-value-per-slot storage
model, predating (per the requirement's own "ahead of the sequencing
behavior introduced in v2.5.0" text) the try_advance/kDefaultState
*behavior* separately cited for REQ-SEQ-004.

REQ-REGMAP-013 -> TC18-12.9.6-004 (Table 30: Error codes in responses):
INVALID_PARAMETER(15) "Request parameter out of range" is the specific
Table-30 row check_read_access/check_write_access/set_endpoint_owner's
invalid_parameter return matches — distinguished from the generic
"-Errc is a distinct category" pattern (REQ-REGMAP-014, skipped below)
by describing one specific error code's semantic trigger condition
rather than the enum-as-a-whole's category-implementation machinery.

REQ-REGMAP-014 -> SKIPPED, same "-Errc is a distinct category" precedent
as REQ-E2E-014 above (generic error_category C++ idiom, not a TC18
clause, even though its four values happen to be Table 30's own names).

REQ-REGMAP-015 -> SKIPPED, same granularity gap as REQ-E2E-005: the
three ep_*_crc_enable booleans are keyed per-endpoint-per-message-role,
which has no literal TC18 counterpart (see REQ-E2E-005's reasoning
above — checked both Table 24's stream-level rx_enforce_crc and
Table 26's BBID-level CRC_required; neither is role-keyed).

== REQ-SEQ-* (11/12 linked) ==

REQ-SEQ-001 -> TC18-11.2.2-002 (Conditional request type identifiers,
Table 5): the mtv=0 message_timestamp-repurposing scheme and the
first-byte-selects-opcode decode this requirement describes is exactly
Table 5's "first byte in message_timestamp field" -> "type of
condition" mapping, introduced by §11.2.2's own "conditional requests
are sent using ACF_GBB having mtv = 0 ... using the bytes of the
message_timestamp field to convey the execution condition" paragraph.

REQ-SEQ-002 -> TC18-12.9.2-003 (Execution priority order across request
types): "In case two or more requests are due for execution then the
priorities are as follows: 1. cancellation 2. triggered 3. timed
4. compound 5. compound wait 6. chained 7. standard" is a verbatim
7-level match for category_of's RequestCategory enum values and
select_next_due's priority_rank ordering (the same paragraph's next
sentence, "starting the execution shall happen in the order ... the
requests arrived," independently covers the FIFO tie-break half of this
requirement, catalogued separately as TC18-12.9.2-004 but not chosen as
primary since the priority list itself is this requirement's dominant
assertion).

REQ-SEQ-003 -> TC18-12.2-004 (Optional compound requests bundle):
verbatim match — "Support of compound requests (0x0F/0x8F) ...
Implementation of at least four sequencers (see 12.10) ... Clear all
non-safestate requests from an EP request storage" is exactly
validate_feature_bundles' compound+compound_wait+clear_non_safestate+
sequencer_count>=kMinCompoundSequencers(4) all-four-required rule.

REQ-SEQ-004 -> TC18-12.9.3-002 (Table 29: Execution procedure, compound
row): "the state of sequencer cmp_sequencer is set to cmp_next_state
if the sequencer state still equals the cmp_start_state, else the
sequencer state is not changed" is a verbatim match for try_advance's
increment-only-if-current-equals-expected_start / leave-unchanged-
otherwise contract. The default-value half (kDefaultState=1) is
separately grounded in TC18-12.7.10-002/-004's "default 1" register
description (already used for REQ-REGMAP-012); this requirement's more
novel/behaviorally-distinctive assertion is the conditional-advance
rule, so Table 29 was chosen as the single master_id.

REQ-SEQ-005 -> TC18-11.2.3-002 (Chained successor cancellation
propagation): "If a request is cancelled to which a request is chained,
then the chained successors shall be cancelled by the RC Server as
well" is a verbatim match for cancel_single's cascade-to-every-
transitive-chained-successor behavior — chosen as the single most
distinctive assertion in this requirement's bundled text; the
Pending/Started-only cancellable window (TC18-11.2.3-001) and the
REQUEST_CANCELED outcome (TC18-11.2.3-003) are the same §11.2.3
paragraph's other two sentences, covering the requirement's remaining
clauses but not separately assigned a master_id.

REQ-SEQ-006 -> TC18-12.9.3-001 (Request lifecycle states pending/RS/
RE/RF): "it is in the state 'request pending' ... enters the state
'request started' (RS) ... advances to 'request under execution' (RE)
... and then to 'request finalized' (RF)" is a verbatim 4-state match
for RequestLedger's Pending->Started->UnderExecution->Finalized
single-step-forward-only state machine.

REQ-SEQ-007 -> TC18-11.2.2.6-011 (Conditional-start (cs) bit semantics
for chained requests): "cs ... 1b: request will not be executed in
case the previous request returned an error ... error response with
error code = CHAIN_ABORTED" is the direct textual basis for
should_execute_chained(successor.cs, errored)'s cascade-cancel-on-error
rule driving RequestLedger::finalize's chained-successor propagation.

REQ-SEQ-008 -> TC18-11.2.2.3-008 (cs-bit execution-due semantics for
compound wait): "If cs = 0, then compound wait request is due for
execution, when the sequencer is in the cmpw_start_state. If cs = 1,
... when EP output state has changed after the sequencer reached the
cmpw_start_state" is the direct textual basis for
compound_wait_check_of's cs->CompoundWaitCheck mapping.
  ** CONFORMANCE FINDING (not fixed in this docs-only PR, flagging for
  a follow-up issue): TC18 states cs=0 -> "due immediately" and
  cs=1 -> "due only after an EP output state change." cpp-RCP's actual
  mapping (include/rcp/request.hpp:371-372, exercised by
  tests/test_request.cpp:520-522) is inverted: cs=true (1) ->
  CompoundWaitCheck::Immediate, cs=false (0) -> AfterChangeOnly — the
  opposite polarity from the spec text quoted above. This master_id is
  still the correct citation for *which clause this requirement's
  subject is drawn from*; the polarity defect is an implementation bug
  independent of the citation and out of scope for this PR (same
  practice as PR #162/#163's conformance-defect flags, which likewise
  documented rather than silently fixed the finding).

REQ-SEQ-009 -> SKIPPED, same "-Errc is a distinct category" precedent
as REQ-E2E-014/REQ-REGMAP-014 above.

REQ-SEQ-010 -> TC18-11.2.2-002 (Table 5, same clause as REQ-SEQ-001):
"0x0F, 0x8F Compound ... 0x0B, 0x8B Compound wait ... 0x0E, 0x8E
Triggered" is Table 5's own enumeration of exactly the three MSB-set
identifier pairs is_valid_request_type/decode_request_type must accept
as CompoundSafety/CompoundWaitSafety/TriggeredSafety.

REQ-SEQ-011 -> TC18-11.2.2-001 (Safety-request retention on MSB-set
condition identifiers, same clause used for REQ-E2E-009/010/012):
"the MSB of the identifier (0x8x) is set the request is treated as a
safety request" is the direct textual basis for is_safety_variant
returning true for exactly the three 0x8x-prefixed opcodes.

REQ-SEQ-012 -> TC18-11.2.3.2-001 (Clear-all-non-safestate-requests
optional cancellation feature): "Clear all non-safestate requests from
an EP request storage ... request_type ... is 0x06" is the named
cancellation operation request_record_for's is_safety derivation feeds
into cancel_all(non_safestate_only=true) — the more precise mechanistic
match versus the general MSB-safety-retention clause used elsewhere,
since this requirement's assertion is specifically about exclusion from
*this* named operation.

== Deliberately untouched (6 of 41) ==

REQ-E2E-005, REQ-REGMAP-015: per-endpoint-per-message-role CRC-enable
granularity has no literal TC18 field; see REQ-E2E-005 reasoning above.
REQ-E2E-013: rx_wd_info_enable / repeating info notification has no
TC18 textual basis found (grepped for notification/repeating/periodic).
REQ-E2E-014, REQ-REGMAP-014, REQ-SEQ-009: generic "-Errc is a distinct
category" C++ idiom, consistent with the precedent set across all 14
other such requirements already present in this file (all unlinked).

== Verification ==

- CMake configure (cmake -B build -DCMAKE_BUILD_TYPE=Release
  -DCMAKE_CXX_STANDARD=17 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
  -DRELAY_BUILD_CLI=ON -G Ninja) + build: clean, 0 errors (219/219
  targets), only pre-existing benign -Wnonnull warnings from a system
  <bits/stl_algobase.h> header, unrelated to this change.
- ctest --test-dir build --output-on-failure -j1: 53/53 passing
  (matches PR #111 baseline).
- cpfusa v0.18.0 check: 0 errors / 2 warnings / 1 info, byte-identical
  before and after this change (FUSA004, FUSA005, HARA005 — all
  pre-existing and unrelated).
- cpfusa v0.18.0 trace --format json coverage: totalRequirements=376,
  tracedRequirements=376, testedRequirements=376, secTestedRequirements=64
  before AND after (confirmed identical via git-stash A/B comparison) —
  this change only adds tc18/tc18_master_id metadata fields, it does not
  touch any fusa:req annotation, test, or requirement count.
- git diff --stat: only .fusa-reqs.json changed, 81 insertions(+),
  12 deletions(-) (the 12 deletions are the "severity"/closing-brace
  lines displaced by each of the 34 new two-line tc18/tc18_master_id
  insertions plus REQ-E2E-011's 1-line citation correction).

Freshness: confirmed via fresh `git clone` at session start (tip
87ba239, matching PR #111 as claimed) and via `git fetch origin` +
`git log --oneline -1 origin/main` immediately before this push — no
new commits landed on main while this batch was in progress.

Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant