Repository navigation
docs: stage 3 missing conditional-request field requirements - #106
Merged
Merged
Conversation
Investigated the REQ-SEQ-* cluster (Compound/CompoundWait/Triggered/ Timed/Chained/Cancel) against TC18 sec 11.2.2/11.2.3 directly, since its 12-requirement count looked thin next to c-RCP's 89 across the equivalent categories. The opcode/routing/state-machine layer is correctly designed (RequestTypeOpcode's 8 real TC18 opcodes, mtv=false repurposing, expected_start_state) -- unlike go-RCP's equivalent layer, this is not a routing defect. But three field-level behaviors are genuinely absent, confirmed by grepping include/ and src/ for the actual TC18 field names: they exist only in comments, never as real fields, variables, or consumed values. - Compound: cmp_exec_delay and cmp_repetitions are undecoded and unenforced -- a Compound request today gates purely on expected_start_state with no delay or repeat-count behavior. - Triggered: trigger_source_ep/trigger_signal_nr/trigger_threshold/ trigger_exec_delay/trigger_repetitions are undecoded -- the opcode is recognized but nothing links a pending request to a specific endpoint+signal+threshold. TriggerRegistry (endpoint.hpp) is a real, working generic per-endpoint signal registry, just not wired to any specific Triggered request's parameters. - Timed: presentation_time (48-bit gPTP) is undecoded -- there is no scheduling/dispatch logic anywhere that defers execution until any point in time; the opcode is recognized but has no distinguishing runtime behavior from a standard request. Per this session's discussion: RELAY spec 20.1.2 hard-gates 100% requirement traceability in CI, so these can't be added to .fusa-reqs.json directly without either breaking the gate or being real (implemented + tested) entries -- neither is true yet. Staged in a new .fusa-reqs-pending.json instead: same schema, not read by cpfusa at all (confirmed: check/trace output unchanged with this file present), to be migrated into .fusa-reqs.json once each gets a real implementation and test. No code change. cpfusa check/trace unaffected (confirmed). Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan