Skip to content

[cpp-RCP-12] CI clang-tidy gate is neutralized by "|| true" #80

Closed

Description

@SoundMatt

Location: .github/workflows/ci.yml:154.

Finding: The clang-tidy step runs with --warnings-as-errors='*' but the whole command is suffixed with || true, so any finding clang-tidy reports is swallowed and the CI job passes regardless. As written, --warnings-as-errors='*' is decorative — it can never actually fail the job.

Recommendation: Remove the || true so genuine clang-tidy findings fail the job, or, if some specific checks are meant to stay advisory-only, scope that explicitly (e.g. via .clang-tidy check-level configuration) rather than blanket-swallowing the whole step's exit code.

Verification: Independently re-read .github/workflows/ci.yml against current HEAD (commit 4b9449a, 2026-07-29). Confirmed line 154 ends in || true immediately after the --warnings-as-errors='*' clang-tidy invocation.

Filed from the 2026-07-29 ecosystem audit register; independently re-verified against current HEAD before filing.

Activity

  1. added a commit that references this issue on Jul 30, 2026
  2. SoundMatt commented on Jul 30, 2026

    @SoundMatt
    OwnerAuthor

    Fixed by #92 (merged), which was not auto-linked because the PR description's bold markdown around the issue numbers broke GitHub's closing-keyword parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions