You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[cpp-RCP-12] CI clang-tidy gate is neutralized by "|| true" #80
Finding: The clang-tidy step runs with --warnings-as-errors='*' but the whole command is suffixed with || true, so any finding clang-tidy reports is swallowed and the CI job passes regardless. As written, --warnings-as-errors='*' is decorative — it can never actually fail the job.
Recommendation: Remove the || true so genuine clang-tidy findings fail the job, or, if some specific checks are meant to stay advisory-only, scope that explicitly (e.g. via .clang-tidy check-level configuration) rather than blanket-swallowing the whole step's exit code.
Verification: Independently re-read .github/workflows/ci.yml against current HEAD (commit 4b9449a, 2026-07-29). Confirmed line 154 ends in || true immediately after the --warnings-as-errors='*' clang-tidy invocation.
Filed from the 2026-07-29 ecosystem audit register; independently re-verified against current HEAD before filing.
Fixed by #92 (merged), which was not auto-linked because the PR description's bold markdown around the issue numbers broke GitHub's closing-keyword parser.
Activity
Merge pull request #92 from SoundMatt/fix/ci-gating-and-safety-docs
SoundMatt commentedon Jul 30, 2026
Fixed by #92 (merged), which was not auto-linked because the PR description's bold markdown around the issue numbers broke GitHub's closing-keyword parser.