Repository navigation
fix: v1.147.0 — ada-FuSa ecosystem-integration gaps - #103
Merged
Merged
Conversation
A support-surface audit found conform/conform.go's langFromBinary and writeSourceFiles had no ada case (silently omitting the Ada scaffold stub instead of erroring), plus CLAUDE.md and README.md still saying "six languages" / omitting adafusa despite ada-FuSa being registered as the 7th adapter since v1.136.0. Signed-off-by: SoundMatt <SoundMatt@users.noreply.github.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| slashReq, slashTest, slashReq) | ||
| return os.WriteFile(filepath.Join(r.dir, "Main.java"), []byte(src), 0o644) | ||
| case "ada": | ||
| if err := os.WriteFile(filepath.Join(r.dir, "conform_test.gpr"), []byte(`project Conform_Test is |
| } | ||
| src := fmt.Sprintf("%s REQ-TEST-001\n%s REQ-TEST-001\n\n%s REQ-TEST-002\n\nprocedure Main is\nbegin\n null;\nend Main;\n", | ||
| dashReq, dashTest, dashReq) | ||
| return os.WriteFile(filepath.Join(r.dir, "main.adb"), []byte(src), 0o644) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A support-surface audit checking whether FuSaOps fully supports ada-FuSa as its 7th language adapter found the Dockerfile/tools-monitor/scan/fleet integration already correct, but three real gaps, all fixed here:
conform/conform.go:langFromBinary/writeSourceFileshad noadacase —fusaops conform --binary adafusa --scaffoldsilently produced no Ada source stub instead of erroring or working. Added, using Ada's--comment convention plus a minimal GNAT project file.CLAUDE.md: still said "six languages today," omitting ada-FuSa.README.md: PATH-tools list and bundled-tools paragraph both omittedadafusa.A fourth gap (ada-FuSa's own release workflow missing the
xfusa-releaseddispatch step) lives in ada-FuSa's repo, out of scope here.Test plan
go build ./...,go vet ./...,go test ./...cleanada/adafusatest cases added toTestLangFromBinary/TestWriteSourceFilesLanguages