Skip to content

fix(android): serialize download progress events #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floyd-soomgo merged 1 commit into from
Aug 3, 2026
Merged

fix(android): serialize download progress events #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,19 +341,28 @@ protected Void doInBackground(Void... params) {
try {
JSONObject mutableUpdatePackage = CodePushUtils.convertReadableToJsonObject(updatePackage);
mUpdateManager.downloadPackage(mutableUpdatePackage, mCodePush.getAssetsBundleFileName(), new DownloadProgressCallback() {
private boolean hasScheduledNextFrame = false;
private DownloadProgress latestDownloadProgress = null;
private volatile boolean hasScheduledNextFrame = false;
private volatile DownloadProgress latestDownloadProgress = null;
private final DownloadProgressEventDispatcher progressEventDispatcher = new DownloadProgressEventDispatcher(
new DownloadProgressEventDispatcher.EventEmitter() {
@Override
public void emit(DownloadProgress downloadProgress) {
getReactApplicationContext()
.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
.emit(CodePushConstants.DOWNLOAD_PROGRESS_EVENT_NAME, downloadProgress.createWritableMap());
}
});

@Override
public void call(DownloadProgress downloadProgress) {
if (!notifyProgress) {
if (!notifyProgress || downloadProgress == null) {
return;
}

latestDownloadProgress = downloadProgress;
// If the download is completed, synchronously send the last event.
if (latestDownloadProgress.isCompleted()) {
dispatchDownloadProgressEvent();
if (downloadProgress.isCompleted()) {
progressEventDispatcher.dispatch(downloadProgress);
return;
}

Expand All @@ -368,22 +377,16 @@ public void run() {
ReactChoreographer.getInstance().postFrameCallback(ReactChoreographer.CallbackType.TIMERS_EVENTS, new Choreographer.FrameCallback() {
@Override
public void doFrame(long frameTimeNanos) {
if (!latestDownloadProgress.isCompleted()) {
dispatchDownloadProgressEvent();
try {
progressEventDispatcher.dispatch(latestDownloadProgress);
} finally {
hasScheduledNextFrame = false;
}

hasScheduledNextFrame = false;
}
});
}
});
}

public void dispatchDownloadProgressEvent() {
getReactApplicationContext()
.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
.emit(CodePushConstants.DOWNLOAD_PROGRESS_EVENT_NAME, latestDownloadProgress.createWritableMap());
}
});

JSONObject newPackage = mUpdateManager.getPackage(CodePushUtils.tryGetString(updatePackage, CodePushConstants.PACKAGE_HASH_KEY));
Expand Down
4 changes: 4 additions & 0 deletions android/app/src/main/java/com/microsoft/codepush/react/DownloadProgress.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,8 @@ public WritableMap createWritableMap() {
public boolean isCompleted() {
return mTotalBytes == mReceivedBytes;
}

long getReceivedBytes() {
return mReceivedBytes;
}
}
23 changes: 23 additions & 0 deletions android/app/src/main/java/com/microsoft/codepush/react/DownloadProgressEventDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package com.microsoft.codepush.react;

class DownloadProgressEventDispatcher {
interface EventEmitter {
void emit(DownloadProgress downloadProgress);
}

private final EventEmitter mEventEmitter;
private long mLastDispatchedBytes = -1;

DownloadProgressEventDispatcher(EventEmitter eventEmitter) {
mEventEmitter = eventEmitter;
}

synchronized void dispatch(DownloadProgress downloadProgress) {
if (downloadProgress == null || downloadProgress.getReceivedBytes() <= mLastDispatchedBytes) {
return;
}

mEventEmitter.emit(downloadProgress);
mLastDispatchedBytes = downloadProgress.getReceivedBytes();
}
}
Loading