fix(card): ignore the retired Bridge endorsement once a card customer exists - #2591
Merged
Merged
Conversation
… exists buildCardSteps fell back to the bridge.xyz "cards" endorsement for every non-Rain issuer, even when /cards/status already reported a kycStatus. For an old Bridge customer applying for a Wirex card, an approved Bridge endorsement marked the KYC step complete and offered "Activate card" before they had verified with Sumsub. The endorsement now only applies to Bridge-only users, who have no card customer and so no kycStatus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PmSmmwX1kxkmMBEP7pVKPG
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the companion to Solid-Money/solid-backend#1869, for the "KYC Routing Issue - Didit Instead of Sumsub" ops ticket.
The backend now reports a superseded Didit rejection (a Rain application from a market Wirex has since taken) as a not-started Wirex application, so the KYC step offers "Continue verification" and routes to Sumsub. The affected user is also an approved bridge.xyz customer.
buildCardStepsfell back to the Bridge "cards" endorsement for every non-Rain issuer, so an approved Bridge endorsement would:The Bridge endorsement now applies only when
/cards/statushas nokycStatus, which means a Bridge-only user with no card customer. Once a Rain/Wirex card customer exists, itskycStatusis the answer. That matches the backend's rule that Bridge is "a fallback for Bridge-only users, not an override".Test plan
buildCardStepstests: an approved Bridge endorsement no longer completes KYC for a Wirexnot_startedapplicant, and still does for a Bridge-only user. The first test fails without the change.jest hooks/useCardSteps: 36/36 pass.tscreports nothing inhooks/useCardSteps.🤖 Generated with Claude Code
https://claude.ai/code/session_01PmSmmwX1kxkmMBEP7pVKPG
Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.