fix(rewards): make the route switch label legible, and name soFUSE - #2539
Merged
Merged
Conversation
Two things a user reading the upgrade screen could not get right. The selected segment's label was white on the white pill, for the third time. The colour was in the `style` prop, which cannot win: `ui/text` prepends `text-foreground` to every label, tailwind-merge only drops it when the label brings a colour class of its own, and on web a Tailwind colour beats the `style` prop outright because react-native-web inserts its stylesheet as `head.firstChild`, below the Tailwind sheet. The class list that shipped was literally `text-foreground web:select-text`. The colour is now declared in both layers, saying the same thing, and the class lives in its own module with a test that asserts the base colour is merged away — the thing that was actually broken. The lock takes soFUSE, the Savings position, not native FUSE. Every screen said "FUSE", which sends people looking in their wallet for a token the lock never touches. The rows now name soFUSE in the label and keep the FUSE the shares are worth in the value — the tier threshold is denominated in FUSE, so both belong on the row — and the prose says plainly that it is soFUSE from Savings and not native FUSE. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGzkz4QFpEZVg6GpNH311x
"You're on Prime now!" appeared over the review screen, on a purchase nobody had made yet. Two things put it there. The celebration is mounted on the protected layout — deliberately, because a tier can arrive from a points milestone, a savings deposit or a trial, and all of them should get the same card — so it draws over whatever screen is up, review screen included. And it measured a promotion against the *last* tier seen, while the backend re-derives the tier from a lock, a subscription row and a soFUSE balance it caches for a minute: a read taken mid-reconciliation can come back a tier low and the next one put it back, which against the last tier is indistinguishable from an upgrade. So it now measures against the highest tier seen this session, where a recovery reads as what it is, and it does not draw at all on the two screens that buy a tier. Suppressed, not cancelled: the success survives in the store, so the card shows the moment the completed purchase replaces the route with Rewards — which is where it was always meant to appear. The fields an account switch clears are exported as one object, because a new field missed in a test's setup leaks between tests, and a leaked high-water mark is a promotion that silently stops being observed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGzkz4QFpEZVg6GpNH311x
…ub card The v3 washes had drifted onto three different diagonals. They run one way now, stated once in `tierGradients` and spread into each gradient: from the top-right corner, where the tint is, to the bottom-left, where it goes black. The upgrade card's backdrop was lit from the opposite corner and now is not; its far end is near-black rather than the grey it faded to. "Join Prime Club" is the deliberate exception and runs the other diagonal, bottom-right to top-left, which puts the heading on the dark corner and the tint under the benefit chips. Its green was also too faint to be green: at 0.16 over #1C1C1C the brand colour lands on rgb(47,62,44), a couple of points off the card it sits on, which reads as grey. It is now unmistakably the tier's colour, with a black stop behind the heading. The benefits screen's two scroll fades are left vertical — they dim content off the top and bottom edges, and a fade only works along the edge it belongs to. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGzkz4QFpEZVg6GpNH311x
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.