fix(prices): Batch Alchemy token price requests to avoid 429 - #2536
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
AxiosError: Request failed with status code 429issue observed on iOS, which was caused by exceeding Alchemy's 10,000 token_price requests/hour rate limit.Root Cause:
The
hooks/useBalances.tsfile was making N parallelGET /by-symbolrequests to Alchemy for N token symbols viaPromise.allSettled(symbolsToFetch.map(s => fetchTokenPriceUsd(s))). EachfetchTokenPriceUsdcall inlib/api.tsmade a single HTTP request, leading to a fan-out that quickly exhausted the rate limit.Solution:
lib/api.ts: Introduced a new exported functionfetchTokenPricesUsdBatch(symbols: string[]). This function accepts an array of token symbols and makes a singleGET /by-symbolrequest to Alchemy, utilizing the endpoint's ability to handle multiple symbols via repeated?symbols=query parameters. It returns aRecord<string, number>mapping symbols to their USD prices, gracefully handling unpriced or failed requests.hooks/useBalances.ts: Modified theuseBalanceshook to replace thePromise.allSettledfan-out with a single call tofetchTokenPricesUsdBatch(symbolsToFetch). The import forfetchTokenPriceUsdwas removed from this file as it's no longer directly used here.lib/__tests__/alchemyTokenPrices.test.ts: Added comprehensive unit tests forfetchTokenPricesUsdBatchto ensure correct batching, parsing of responses, and error handling.The existing
fetchTokenPriceUsdfunction remains unchanged to support its other callers (e.g.,useEstimateGas.ts,useNativePriceUsd.ts,useToken.tsx).Fixes SOLID-ZZ
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.