Fix: iOS passkey cancellations logged as exceptions - #2534
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where user-cancelled passkey login prompts on iOS devices were incorrectly captured as exceptions in Sentry, rather than being treated as benign warnings.
Problem:
On iOS (Expo/React Native), when a user cancels a passkey login prompt, the error object received has
error.name === 'UserCancelled'and a message like'The user cancelled the request.'. The existing error handling inhooks/useUser.tsat line 434 only checked forerror?.name === 'NotAllowedError'to identify user cancellations. As a result, iOS cancellations fell into the genericelseblock, triggeringSentry.captureException(new Error('Error logging in')).Root Cause:
The
isWebAuthnUserCancelledErrorhelper inlib/execute.tsalready contains logic to correctly identify various forms of user-cancelled WebAuthn prompts, including those with'user cancelled'in the message. However, this helper was not being used in the login error handling path inhooks/useUser.ts.Solution:
isWebAuthnUserCancelledErrorfrom@/lib/executeintohooks/useUser.ts.hooks/useUser.tsto include theisWebAuthnUserCancelledError(error)check. This ensures that iOS-specific cancellation errors are now correctly identified and logged as warnings, preventing unnecessary Sentry exceptions.lib/__tests__/execute.test.tsto specifically cover theisWebAuthnUserCancelledErrorhelper, including a test case for the iOSUserCancellederror shape.This change ensures that user-initiated cancellations are handled gracefully across all platforms, improving error reporting accuracy.
Fixes SOLID-ZN
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.