Move link icon inside anchor on Login page - #142
Merged
Conversation
Owner
|
Hi @PVSCH, can you send a screenshot after your changes |
Contributor
Author
|
How about I make a video and post it here? I think a screenshot doesn't make any difference. so what do u say, mate |
Owner
|
Sure @PVSCH , you can do that 👍 |
Contributor
Author
|
The link below will show the video preview of my work |
Contributor
Author
|
Thank you for the opportunity, i learned a few things about .NET, even though I was a beginner in it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Updated Views/Account/Login.cshtml so the external‑link icon sits inside the anchor with the label;
Why: Makes the icon clickable with the text and meets the issue’s requirement; improves accessibility and user experience.
Testing: Ran locally at http://localhost:5073/, verified that both text and icon open the OWASP AspGoat page in a new tab