Repository navigation
CI: test Maven 4 on 4.0.0-rc-7 (#267) - #1443
Merged
Mikola Lysenko (mikolalysenko) merged 2 commits intoOct 12, 2026
Merged
Conversation
The nightly full tier still tested Maven 4 on 4.0.0-rc-6, which 4.0.0-rc-7 has superseded, so Maven 4 regressions users hit on the current release candidate could go unnoticed. Move both 4.x legs (redirect + vendor builds, and the vendored reactor) to rc-7 and replace the rc-6 SHA512 pin with rc-7's, taken from Apache's published checksum. Same legs, same tier: no change in runner use. Refs #267 Assisted-by: Claude Code:claude-opus-5-5
This was referenced Oct 12, 2026
Open
The Maven vendoring design doc said the PR tier pins five Maven versions, but since lean CI only 3.9.16 runs on PRs and in the merge queue; the rest, plus 3.9.3 and 3.9.4, run in the nightly full tier. Also point two code comments that cite the Maven 4 release they were checked against at rc-7, which the e2e suites now run and pass on. Refs #267 Assisted-by: Claude Code:claude-opus-5-5
Mikola Lysenko (mikolalysenko)
marked this pull request as ready for review
October 12, 2026 19:05
Collaborator
Author
|
BugBot review Generated by Claude Code |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8fc25a3. Configure here.
Tanmay Singla (Tanmay182003)
approved these changes
Oct 12, 2026
Mikola Lysenko (mikolalysenko)
deleted the
agent/fix-ci-maven-4-rc7-pin
branch
October 12, 2026 19:59
This was referenced Oct 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-opus-5-5
Refs #267
What
The nightly full tier tested Maven 4 on
4.0.0-rc-6.4.0.0-rc-7is now the newest Maven 4 release on Maven Central, so the 4.x pin was stale (the "stale 4.0 RC" part of #267). This moves both 4.x legs ofe2e-extendedto rc-7:e2e_redirect_maven_build e2e_vendor_maven_build, maven4.0.0-rc-7e2e_vendor_jvm_build --ignored maven_reactor, maven4.0.0-rc-7scripts/maven-sha512.jsondrops the rc-6 pin and adds rc-7's SHA512, taken from Apache's publishedapache-maven-4.0.0-rc-7-bin.tar.gz.sha512(archive.apache.org) and matched against the downloaded tarball.docs/design/maven-vendoring.mdnames the new pin and now says which tier runs each Maven version (it said "the PR tier", but since lean CI only 3.9.16 runs on PRs). Two code comments that cite the Maven 4 release they were checked against now say rc-7.Runner usage
Same legs in the same tier (full tier only: schedule / dispatch /
CI_SCOPE=full). Lean PR and merge-queue runs: before ~28 Linux jobs / ~32 job-min, after the same. No change.Not in this PR (stays open on #267)
e2e_redirect_maven_build/e2e_vendor_maven_buildleg.Both add full-tier jobs, so they need a call on nightly cost first.
Test evidence
Local, against the downloaded
apache-maven-4.0.0-rc-7(mvn -v:Apache Maven 4.0.0-rc-7 (6d8f301b), Java 21), with the env CI sets (SOCKET_PATCH_MAVEN_E2E_REQUIRED=1,SOCKET_PATCH_MAVEN_E2E_VERSION=4.0.0-rc-7, so the suite fails ifmvn -vreports another version;maven_build_common/mod.rs:155):e2e_redirect_maven_build --ignored: 1 passede2e_vendor_maven_build --ignored: 1 passede2e_vendor_jvm_build --ignored maven_reactor: 1 passedpython3 -m pytest scripts/tests -q: 342 passed, 6 skipped (includestest_every_matrix_version_has_a_sha512_pin)actionlintandzizmor --offlineonci.yml: same output as onorigin/main(no new findings); the workflow YAML parses.cargo fmt --all -- --check,cargo clippy -p socket-patch-core --all-features -- -D warnings: clean (only comments changed in Rust files).No full-scope dispatch: no platform-specific code changed, and the three rc-7 suites already pass locally, so one full matrix run (~90 jobs) wasn't worth the runners.
/code-review high: findings not fixed here
Assisted-by:rather thanCo-Authored-By:, per this repo's agent conventions.🤖 Generated with Claude Code
https://claude.ai/code/session_0132UUYumjHCgWoZX7hDMGqD
Generated by Claude Code