fix: race condition where artifacts from late resolving flights could be silently dropped#14
Open
Bill Li (billxinli) wants to merge 2 commits intomainfrom
Open
fix: race condition where artifacts from late resolving flights could be silently dropped#14Bill Li (billxinli) wants to merge 2 commits intomainfrom
Bill Li (billxinli) wants to merge 2 commits intomainfrom
Conversation
Bill Li (billxinli)
commented
Apr 16, 2026
- Fix race condition where fetchStrategy pushed into a shared artifacts array by reference late resolving flights could write into a stale array that had already been yielded, silently dropping results
- Change fetchStrategy to return artifacts instead of mutating a passed in array, so the scanner factory controls when results are merged via a closure that always reads the current array
- Add tests covering late-resolving flights
3840fdd to
e4f6eb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.