Skip to content

th-6784a6: sync to core@main + pin CI core checkout (unblock all PR CI)#183

Merged
brentrager merged 1 commit into
mainfrom
th-6784a6-core-sync
Jul 5, 2026
Merged

th-6784a6: sync to core@main + pin CI core checkout (unblock all PR CI)#183
brentrager merged 1 commit into
mainfrom
th-6784a6-core-sync

Conversation

@brentrager

Copy link
Copy Markdown
Contributor

Problem

pr-kind-deploy-smoke.yml checks out SmooAI/smooth-operator-core with no ref, so it builds against core@main. When core@main advanced (added the multimodal Message.images field + dep changes), this repo's main stopped compiling against it and cargo build --locked failed the lock check — turning every open PR red for reasons unrelated to its own diff (e.g. #182).

Fix (unblock + structurally prevent recurrence)

  • runtime.rs / runner.rs: add images: vec![] to the two replayed-history EngineMessage constructions (text-only history, no attachments).
  • Stale test literals missing new struct fields: suggested_replies.rs (identity_intakeinteractions, folded into Rich Interactions in Rich Interactions: extensible structured-interaction framework (identity intake = first kind) #176) and serve_smoke.rs (ServerConfig + TurnRequest new fields).
  • Regenerate Cargo.lock against core@main (cargo update -p smooai-smooth-operator-core) so --locked passes.
  • Pin the CI core checkout to 3c7b21dbde4f31519b2eab3d5343f154119fe655, documented as interim until core publishes to crates.io. A moving core@main can no longer silently break CI; adopting a newer core is now a deliberate SHA bump alongside the cargo update.

Not in scope

Does not publish smooai-smooth-operator-core to crates.io and does not switch the path dep to a crates version — that's the separate, deliberate migration Brent + team-lead are handling.

Gates

cargo fmt --check, cargo clippy (no errors), cargo test --workspace (69 test binaries, 0 failed), and cargo build --locked — all green against the pinned core. Changeset added.

Once this lands, main is green again and #182 (OTel spans) becomes mergeable (rebase to pick up the pin + lock).

🤖 Generated with Claude Code

pr-kind-deploy-smoke.yml checked out SmooAI/smooth-operator-core with no `ref`,
so when core@main advanced (multimodal `Message.images` field), this repo's main
stopped compiling against it and `cargo build --locked` failed the lock check —
turning EVERY open PR red for reasons unrelated to its own diff.

Why pin: the cross-repo path-dep means a moving core@main is an uncontrolled
input to this repo's CI. Pinning to a known-good SHA makes core adoption a
deliberate, reviewable bump instead of a silent break. Interim until core
publishes to crates.io and the cross-repo checkout goes away.

- runtime.rs / runner.rs: add `images: vec![]` to the replayed-history
  EngineMessage constructions (text-only, no attachments).
- Fix stale test literals missing new struct fields: suggested_replies.rs
  (`identity_intake` → `interactions`, folded in #176) and serve_smoke.rs
  (ServerConfig + TurnRequest new fields).
- Regenerate Cargo.lock against core@main (`cargo update -p
  smooai-smooth-operator-core`) so `--locked` passes.
- Pin the CI core checkout to 3c7b21dbde4f31519b2eab3d5343f154119fe655.

Gates: cargo fmt --check, cargo clippy (no errors), cargo test --workspace
(69 test binaries, 0 failed), and `cargo build --locked` all green against the
pinned core.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9c1ef51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@smooai/smooth-operator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brentrager brentrager merged commit 25adb5c into main Jul 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant