fix(#500): avoid double-conversion in unlockAssets wrapper - #507
Merged
ritaifeoluwa merged 1 commit intoOct 1, 2026
Merged
ritaifeoluwa merged 1 commit into
ritaifeoluwa merged 1 commit into
Conversation
The unlockAssets wrapper was validating the amount by calling amountToStroops() and discarding the result, then the service would call amountToStroops() again for the actual conversion. Now the wrapper captures the converted stroops value and passes it to the service via a new optional parameter, avoiding the redundant conversion while maintaining fail-fast validation before wallet interaction. Closes SmartDropLabs#500
|
@Hotmopo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.
|
❌ Deploy Preview for smart-drop failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unlockAssets wrapper was validating the amount by calling
amountToStroops()and discarding the result, then the service would callamountToStroops()again for the actual conversion.Now the wrapper captures the converted stroops value and passes it to the service via a new optional
amountStroopsparameter, avoiding the redundant conversion while maintaining fail-fast validation before wallet interaction.Closes #500