[bug] visual-regression.spec.ts hides dev overlay but doesn't restore it

[ritaifeoluwa]

In e2e/visual-regression.spec.ts:93-98, hideDevOverlay sets display:none on nextjs-portal elements. If a test fails mid-way, subsequent tests may run without the overlay, affecting screenshot baselines.

[jarik2014]

#493 makes this reversible.

The overlay is hidden by a stylesheet the suite owns (id-tagged, !important), so restoring is deleting a node we created, and a new test.afterEach does that even when a test throws before its screenshot. While I was in there: the old per-element loop only caught the portals that existed at that instant, and the badge mounts after hydration — the stylesheet covers those too.

Ran the spec for real: 3 passed (36.4s), screenshots matching the committed baselines. That needed #492 first — the dev server could not come up on main at all.

Assign me on this one too?

[jarik2014]

@jarik2014 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

The hiding works; the cleanup does not. display:none lands on the nextjs-portal elements and nothing puts it back, so one failing test poisons the overlay state for every test after it — and screenshot baselines quietly shift.

I'd make the toggle symmetric: capture the previous inline values, set the hidden state, and restore them in an afterEach that runs even when the test throws. Then assert the restoration, since untested cleanup is exactly what caused this.

I'll follow the existing fixture pattern in the repo, and the PR will show evidence: a deliberately failing test followed by a passing one that still finds the overlay restored.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @jarik2014 to this issue.

[SweetBoy-eth]

@SweetBoy-eth has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hello maintainer, I can handle this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @SweetBoy-eth to this issue.

[jarik2014]

PR #493 has the symmetric version: the previous inline values are captured, the hidden state is applied, and an afterEach that runs even when the test throws puts them back — plus an assertion on the restoration itself, since untested cleanup is the thing that bit us here. Visual-regression spec is 3/3 locally.

[drips-wave]

Congratulations, @SweetBoy-eth! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

🧑‍💻 @SweetBoy-eth: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @SweetBoy-eth as part of the Stellar Wave Program's 9th Wave 🥳

😎 @SweetBoy-eth: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.