[bug] E2E farm.spec.ts uses window.__queryClient for test seeding

[ritaifeoluwa]

In e2e/farm.spec.ts:175-192, tests seed React Query data via window.__queryClient. This couples E2E tests to the internal QueryClient instance and breaks if the global is removed.

[QwinDivy]

@QwinDivy has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi Maintainer, I'd love to take this one on. I've gone through the codebase and I'm comfortable with the approach needed here. I'll keep the change focused, add tests, and make sure CI stays green. Happy to open a draft early so we can align on direction.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @QwinDivy to this issue.

[cold-13]

@cold-13 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

hey maintainer kindly assign this to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @cold-13 to this issue.

[jarik2014]

Opened #490 for this.

The specs now seed through a small surface the app installs itself — window.__e2e.seedPools(...), seedPositions(...), clearPositions(...), reset() — built from QUERY_KEYS in useSorobanQuery, and window.__queryClient is no longer published at all. lock-unlock-lifecycle.spec.ts used the same global for the same reason, so it moved over too. There is a unit test that fails if any spec under e2e/ reaches for the old global again, so it cannot come back quietly.

Could you assign this to me (@jarik2014)? The work is done and waiting on review, and I would rather it be credited here than sit unassigned.

[jarik2014]

@jarik2014 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

The seeding in e2e/farm.spec.ts:175-192 reaches into window.__queryClient, which means the test knows about an internal React Query instance instead of the app's public surface — and it breaks the day that global goes away.

I'd replace it with a mechanism that survives the refactor: seed through the app's own data path (Playwright route interception or whatever seeding the other specs already use) and assert the UI ends up in the state the seed intended, so the test is verified by the rendered result rather than by having poked a global.

Plan: read how the other specs seed data and follow that pattern instead of inventing a second one, keep the current assertions intact, and run the e2e suite plus typecheck and lint before the PR. If a global really is the only reliable path in this repo, I'll say so and justify it rather than forcing a rewrite.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @jarik2014 to this issue.

[SweetBoy-eth]

@SweetBoy-eth has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hello maintainer, I can handle this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @SweetBoy-eth to this issue.

[jarik2014]

The PR for this is up: #490. It replaces window.__queryClient with a window.__e2e seeding hook that the app itself owns, and migrates both specs that leaned on the old global rather than leaving one of them coupled to it. e2e farm spec passes 5/5 locally. If you would rather keep the global and seed through route interception instead, say so and I will rework it that way.

[drips-wave]

Congratulations, @SweetBoy-eth! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

🧑‍💻 @SweetBoy-eth: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @SweetBoy-eth as part of the Stellar Wave Program's 9th Wave 🥳

😎 @SweetBoy-eth: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.