Skip to content

fix: WS shutdown, cacheWarm count, eventParser flat data, webhook validation - #425

Merged
ritaifeoluwa merged 1 commit into
SmartDropLabs:mainfrom
chukwuemekarita:fix/ws-shutdown-cache-warm-event-parser-webhook-validation
Sep 25, 2026
Merged

ritaifeoluwa merged 1 commit into
SmartDropLabs:mainfrom
chukwuemekarita:fix/ws-shutdown-cache-warm-event-parser-webhook-validation

Conversation

@chukwuemekarita

Copy link
Copy Markdown
Contributor

Closes

Closes #411
Closes #412
Closes #413
Closes #414

What changed

How to test

  1. [enhancement] No graceful shutdown for WebSocket server #414: Call shutdown(wss) with active connections — connections should close with code 1001 and heartbeat should stop
  2. [bug] cacheWarm reports 0 succeeded when timeout fires even if some succeeded #413: Trigger cache warm with a short timeout — summary should show actual succeeded count, not 0
  3. [bug] eventParser dataFromValue fallback returns { value } for non-array non-object values #412: Parse an event with a non-object/non-array value — data field should be the value directly, not { value }
  4. [bug] deliveryRepository create does not validate webhook_id exists #411: Call deliveryRepository.create() with a non-existent webhook_id — should throw an error

…data, webhook validation

- SmartDropLabs#414: Add shutdown() to priceWebSocket.js that drains connections via
  PriceSubscriptionManager.drain() before closing the server
- SmartDropLabs#413: Track succeeded count incrementally in cacheWarm.js so the timeout
  handler reports real progress instead of hardcoding succeeded: 0
- SmartDropLabs#412: Return value directly instead of { value } wrapper for non-array
  non-object decoded values in eventParser.dataFromValue
- SmartDropLabs#411: Validate webhook_id exists via webhookRepository.findById before
  creating delivery records to prevent orphaned deliveries
@drips-wave

drips-wave Bot commented Sep 25, 2026

Copy link
Copy Markdown

@chukwuemekarita Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@ritaifeoluwa
ritaifeoluwa merged commit 073d853 into SmartDropLabs:main Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants