Repository navigation
fix: WS shutdown, cacheWarm count, eventParser flat data, webhook validation - #425
Merged
ritaifeoluwa merged 1 commit intoSep 25, 2026
Conversation
…data, webhook validation - SmartDropLabs#414: Add shutdown() to priceWebSocket.js that drains connections via PriceSubscriptionManager.drain() before closing the server - SmartDropLabs#413: Track succeeded count incrementally in cacheWarm.js so the timeout handler reports real progress instead of hardcoding succeeded: 0 - SmartDropLabs#412: Return value directly instead of { value } wrapper for non-array non-object decoded values in eventParser.dataFromValue - SmartDropLabs#411: Validate webhook_id exists via webhookRepository.findById before creating delivery records to prevent orphaned deliveries
|
@chukwuemekarita Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Closes #411
Closes #412
Closes #413
Closes #414
What changed
[enhancement] No graceful shutdown for WebSocket server #414 — Added
shutdown(wss, drainTimeoutMs)tosrc/ws/priceWebSocket.jsthat callssubscriptionManager.drain()to gracefully close all connections before closing the server. Exported for use in process shutdown handlers.[bug] cacheWarm reports 0 succeeded when timeout fires even if some succeeded #413 — Fixed
src/startup/cacheWarm.jsto tracksucceededSoFarincrementally as each fetch resolves, so the timeout handler reports the real success count instead of hardcodingsucceeded: 0.[bug] eventParser dataFromValue fallback returns { value } for non-array non-object values #412 — Fixed
src/indexer/eventParser.jsdataFromValueto return the value directly instead of wrapping in{ value }for non-array non-object decoded values (strings, numbers, bigints).[bug] deliveryRepository create does not validate webhook_id exists #411 — Added
webhookRepository.findById(webhook_id)validation insrc/repositories/deliveryRepository.jscreate()to reject delivery records for non-existent webhooks.How to test
shutdown(wss)with active connections — connections should close with code 1001 and heartbeat should stop{ value }deliveryRepository.create()with a non-existent webhook_id — should throw an error