[DON-3563] Add contentDescription to BpkSearchInputControl

[peterliu (peterInTown)]

Summary

• Adds a required contentDescription parameter to BpkSearchInputControl / BpkControlFieldImpl, so the field's accessible label can be set explicitly.
• Uses clearAndSetSemantics on the control field's Box so TalkBack announces a single, explicit description instead of a merged one built from child nodes (prefix, value, placeholder).
• Updates SearchInputControlStory demo call sites with example descriptions.

Test plan

• Run the app and verify SearchInputControlDockedStack renders correctly
• Enable TalkBack and confirm each search input field announces only the intended contentDescription

[skyscanner-backpack-bot]

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️	One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against c217653

[Copilot]

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds an explicit accessibility label to BpkSearchInputControl so TalkBack announces a single, intended description instead of a merged string from child semantics.

Changes:

• Introduces a required contentDescription parameter on BpkSearchInputControl and threads it into BpkControlFieldImpl.
• Applies clearAndSetSemantics on the control field container to override merged child semantics.
• Updates demo story call sites with example content descriptions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/textfield/internal/BpkControlFieldImpl.kt	Overrides container semantics to provide a single accessible label.
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/searchinputcontrol/BpkSearchInputControl.kt	Makes contentDescription a required public API param and forwards it to the internal control field.
app/src/main/java/net/skyscanner/backpack/demo/compose/SearchInputControlStory.kt	Updates demo usage with example content descriptions.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[peterliu (peterInTown)]

It is fine, there is no useage for SearchInputControl in the main app at the moment

[Henrik Sym (henrik-sky)]

Change label to major please

[Lokmane Krizou (LokmaneKrizou)]

peterliu (@peterInTown) plus 1 to copilot, we should be using stringResource instead. other stories use stringResource, lets not introduce hardcoded strings

[mldtms]

it's a demo so I guess plan strings are accepted here, so it's okay.

[Henrik Sym (henrik-sky)]

The clear action is visually present but inaccessible. BpkControlFieldImpl applies clearAndSetSemantics to the whole field, which hides descendant semantics. I verified this on the running story with BpkClearAction: the X is visible, but the accessibility tree exposes only one clickable/focusable node, Departing from London; there is no Clear departure airport action/node. That prevents TalkBack users from discovering or activating clear. Please preserve/expose the clear-action semantics while retaining the single field label, and avoid wiping caller-provided semantics.

[skyscanner-backpack-bot]

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️	One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against cdc6642

[skyscanner-backpack-bot]

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️	One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 91f996d

[Henrik Sym (henrik-sky)]

Approved as major change