add item model support#8779
Open
novystar wants to merge 11 commits into
Open
Conversation
novystar
requested review from
Burbulinis and
TheMug06
and removed request for
a team
July 16, 2026 17:39
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
APickledWalrus
requested changes
Jul 16, 2026
APickledWalrus
left a comment
APickledWalrus
left a comment
Member
There was a problem hiding this comment.
Looks pretty good overall from a quick look - mainly just some formatting
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
Contributor
Author
|
thanks pickle, changes have been made :) |
Absolutionism
requested changes
Jul 16, 2026
skriptlang-automation
Bot
removed
the
needs reviews
AnOwlBe
approved these changes
Jul 17, 2026
skriptlang-automation
Bot
added
the
enhancement
skriptlang-automation
Bot
removed
the
needs triage
Absolutionism
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skript doesn't natively support custom item models (different to custom model data).
Solution
added ExprItemModel and ExprItemWithModel, so you can now do:
Testing Completed
tests/bukkit/item/ExprItemModel.sk
Supporting Information
Completes: #8140
Related: none
AI assistance: none