Client side stuff#8704
Open
AnOwlBe wants to merge 29 commits into
Open
Conversation
AnOwlBe
requested review from
Burbulinis and
Efnilite
and removed request for
a team
June 14, 2026 23:32
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
Absolutionism
requested changes
Jun 15, 2026
skriptlang-automation
Bot
removed
the
needs triage
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
…Stuff # Conflicts: # src/main/java/org/skriptlang/skript/bukkit/entity/player/elements/effects/EffSendBlockDamage.java
…e & ExprWeather to use newer registry & be in SkriptLang folder.
Contributor
Author
|
This is ready-for-review now |
Absolutionism
requested changes
Jun 17, 2026
| public static void register(SyntaxRegistry syntaxRegistry) { | ||
| syntaxRegistry.register(SyntaxRegistry.EFFECT, SyntaxInfo.builder(EffSendExperienceChange.class) | ||
| .supplier(EffSendExperienceChange::new) | ||
| .addPatterns("make %players% see their [own] (experience|exp|xp) as level %integer% with %number% progress") |
Contributor
There was a problem hiding this comment.
Thoughts on allowing only level and only progress?
Changing only the level could set the progress to 0 perhaps?
Changing progress could keep the player's current level?
Contributor
Author
There was a problem hiding this comment.
I could make progress optional but I think level should be required
Member
There was a problem hiding this comment.
The API does allow only sending progress though. Another pattern might not hurt IMO. Maybe a pattern to reset it too? Like the other syntaxes have.
Contributor
Author
There was a problem hiding this comment.
could make the level optional & put progress before level & add a pattern for reset which would simply just set the experience to the player's current
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
sovdeeth
requested changes
Jun 22, 2026
skriptlang-automation
Bot
added
needs reviews
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
requested changes
Jun 23, 2026
skriptlang-automation
Bot
removed
the
needs reviews
…nts/effects/EffSendBlockDamage.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
…nts/effects/EffSendBlockDamage.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
approved these changes
Jun 23, 2026
skriptlang-automation
Bot
added
the
needs reviews
APickledWalrus
requested changes
Jul 1, 2026
| @Example("add 54 real seconds to time of world \"world\" # approximately 1 minecraft hour") | ||
| @Example("set client time of player to 2:00") | ||
| @Since("1.0, INSERT VERSION (player support)") | ||
| public class ExprTime extends PropertyExpression<Object, Time> { |
Member
There was a problem hiding this comment.
This could probably be a SimplePropertyExpression
Contributor
Author
There was a problem hiding this comment.
aren't SimplePropertyExpressions more for simpler stuff this doesn't really seem simple considering its handling time of worlds & players with an object
| public static void register(SyntaxRegistry syntaxRegistry) { | ||
| syntaxRegistry.register(SyntaxRegistry.EFFECT, SyntaxInfo.builder(EffSendExperienceChange.class) | ||
| .supplier(EffSendExperienceChange::new) | ||
| .addPatterns("make %players% see their [own] (experience|exp|xp) as level %integer% with %number% progress") |
Member
There was a problem hiding this comment.
The API does allow only sending progress though. Another pattern might not hurt IMO. Maybe a pattern to reset it too? Like the other syntaxes have.
skriptlang-automation
Bot
removed
the
needs reviews
Contributor
Author
possibly though there has to be atleast 1 pattern allowing both else it'd be impossible to send em both without one overriding the other
|
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skript was missing what small stuff bukkit/paper offers for client side stuff & on top of that EffSendBlockChange was running on deprecated methods & class was a tad bit messy (atleast in my opinion)
Solution
Changes to EffSendBlockChange made the syntaxstringbuilder a bit more clean changed it to use SendMultiBlockChange which is much more efficient than sending a whole new packet for every single location provided (this is an up for debate thing as paper has marked
Position(which it uses) as experimental so I will revert changes back for this if needed)Progress:
Testing Completed
Manual testing completed everything appears to work flawlessly
Supporting Information
Completes: #8490
Related: none
AI assistance: just some for debugging issues