Fix EffFeed by hotpoc · Pull Request #8702 · SkriptLang/Skript

hotpoc · 2026-06-12T04:18:44Z

Problem

The person who updated the now current feed effect forgot to add a max level, so it stacks every time you do the normal feed player. I think it should instead only go above the max if specified with by %-number%, as it makes more sense logically (at least in my head).

Solution

It fixes it by just setting the food level to 20 if the beef amount isn't set.

Testing Completed

I did:
!feed player
!send food level of me

!feed player by 40
!send food level of me

And it seemed to work fine

Supporting Information

I guess it's a breaking change if players are using it specifically to stack feed themselves? I don't see why anyone would, though.

Completes: none
Related: none
AI assistance: none

AnOwlBe · 2026-06-12T04:21:03Z

wonder if this would be better as an expr eg set saturation of player to 5 add 5 to saturation of player

edit: nvm ignore me that already exists

TheMug06 · 2026-06-12T08:17:28Z

Please target dev/patch or dev/feature

TheMug06

lgtm apart from requested change and base branch

AnOwlBe · 2026-06-12T08:29:18Z

am I missing something or did you remove the registry just to replace it with the older deprecated registry-

TheMug06 · 2026-06-12T08:38:01Z

Oop i forgot about the new registry
Yeah please stick to the new registry!!!

hotpoc · 2026-06-13T00:26:42Z

am I missing something or did you remove the registry just to replace it with the older deprecated registry-

i was gonna use the newer one but all the files i checked that used it all had their own module things to register them with. i didn't really know where to put it. where should it go?

AnOwlBe · 2026-06-13T00:35:23Z

in playermodule as its relating to feeding a player

stale

APickledWalrus · 2026-06-30T21:24:58Z

+		return "feed " + players.toString(event, debug) + (beefs != null ? " by " + beefs.toString(event, debug) : "");
+	}




Suggested change

extraneous space

APickledWalrus · 2026-06-30T21:25:38Z

@@ -20,41 +21,41 @@
 @Since("2.2-dev34")
 public class EffFeed extends Effect {


This class should also be moved to the PlayerModule directory. specifically org/skriptlang/skript/bukkit/entity/player/elements/effects

APickledWalrus · 2026-06-30T21:27:14Z

+			Number n = beefs.getSingle(event);
+			if (n != null)
+				foodAmount = n.intValue();


I would retain the behavior of terminating if n is null.

AnOwlBe

I forgot to click 'submit review' on these 2 weeks ago but should still apply by now

AnOwlBe · 2026-06-13T21:38:00Z

@@ -1,17 +1,18 @@
 package ch.njol.skript.effects;


should be in org/skriptlang/skript/bukkit/entity/player/elements/effects

AnOwlBe · 2026-06-13T21:40:11Z

-    private Expression<Number> beefs;
-
-    @Override
-    public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, SkriptParser.ParseResult parseResult) {


Should use ParseResult not SkriptParser.ParseResult

AnOwlBe · 2026-06-13T21:41:18Z

+
+	@Override
+	public String toString(@Nullable Event e, boolean debug) {
+		return "feed " + players.toString(e, debug) + (beefs != null ? " by " + beefs.toString(e, debug) : "");


could use SyntaxStringBuilder

AnOwlBe · 2026-06-13T21:41:57Z

+	@SuppressWarnings("null")
+	private Expression<Player> players;
+	@Nullable
+	private Expression<Number> beefs;


Just my thoughts but why is this named beefs? couldn't it be named something like amount

i dont know bro

AnOwlBe · 2026-06-13T21:43:47Z

 		register(addon,
 			EffBan::register,
 			EffKick::register,
+			EffFeed::register,


Should be before EffKick I believe

AnOwlBe · 2026-06-13T22:00:35Z

-    }
+	public static void register(SyntaxRegistry registry) {
+		registry.register(SyntaxRegistry.EFFECT, SyntaxInfo.builder(EffFeed.class)
+			.addPatterns("feed %players% [by %-number% [beef[s]]]")


I believe someone already asked this in another pr or at some point but why is there beef in the syntax it just seems off

i dont know bro its optional though

well atleast imo it should be removed as its kind of misleading as if you eat beef/steak ingame it feeds by 6 health so if you do feed player by 1 beef kind of misleading

though for this pr probably not best idea as it'd cause breaking changes

Beefs, as that's what the hunger bars could be refered to, don't see the use in removing it, would just cause it to break for anyone using it.

hotpoc added 3 commits June 11, 2026 23:46

Fix Feed Effect

cb0e612

Fix Feed Effect

8ec0eb3

Fix Feed Effect

74536cb

hotpoc requested a review from a team as a code owner June 12, 2026 04:18

hotpoc requested review from Efnilite and Pesekjak and removed request for a team June 12, 2026 04:18

skriptlang-automation Bot added needs reviews A PR that needs additional reviews needs triage An issue that hasn't been classified or verified yet labels Jun 12, 2026

This comment has been minimized.

Sign in to view

skriptlang-automation Bot added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jun 12, 2026

skriptlang-automation Bot added this to 2.16 Releases Jun 12, 2026

skriptlang-automation Bot moved this to In Review in 2.16 Releases Jun 12, 2026

skriptlang-automation Bot removed the needs triage An issue that hasn't been classified or verified yet label Jun 12, 2026

TheMug06 requested changes Jun 12, 2026

View reviewed changes

Comment thread src/main/java/ch/njol/skript/effects/EffFeed.java Outdated

TheMug06 previously requested changes Jun 12, 2026

View reviewed changes

Comment thread src/main/java/ch/njol/skript/effects/EffFeed.java Outdated

hotpoc changed the base branch from master to dev/patch June 13, 2026 00:56

Fix Feed Effect

ba917ab

hotpoc requested a review from TheMug06 June 13, 2026 01:18

TheMug06 reviewed Jun 13, 2026

View reviewed changes

Comment thread src/main/java/ch/njol/skript/effects/EffFeed.java

hotpoc requested a review from TheMug06 June 16, 2026 00:28

Absolutionism requested changes Jun 18, 2026

View reviewed changes

Comment thread src/main/java/ch/njol/skript/effects/EffFeed.java Outdated

Comment thread src/main/java/ch/njol/skript/effects/EffFeed.java Outdated

Comment thread src/main/java/ch/njol/skript/effects/EffFeed.java Outdated

Absolutionism's Requested Changes

2cd1018

hotpoc requested a review from Absolutionism June 19, 2026 22:19

sovdeeth approved these changes Jun 22, 2026

View reviewed changes

skriptlang-automation Bot removed the needs reviews A PR that needs additional reviews label Jun 22, 2026

Absolutionism approved these changes Jun 27, 2026

View reviewed changes

Comment thread src/main/java/ch/njol/skript/effects/EffFeed.java Outdated

skriptlang-automation Bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jun 27, 2026

hotpoc and others added 2 commits June 28, 2026 10:42

Absolutionism's Requested Changes Again

7018aaa

Merge branch 'dev/patch' into master

cf6e919

APickledWalrus requested changes Jun 30, 2026

View reviewed changes

skriptlang-automation Bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jun 30, 2026

AnOwlBe suggested changes Jun 30, 2026

View reviewed changes

APickledWalrus removed this from 2.16 Releases Jul 1, 2026

APickledWalrus added this to 2.17 Releases Jul 1, 2026

github-project-automation Bot moved this to In Review in 2.17 Releases Jul 1, 2026

APickledWalrus removed this from 2.17 Releases Jul 1, 2026

APickledWalrus added this to 2.16 Releases Jul 1, 2026

github-project-automation Bot moved this to In Review in 2.16 Releases Jul 1, 2026

APickledWalrus added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 1, 2026

		return "feed " + players.toString(event, debug) + (beefs != null ? " by " + beefs.toString(event, debug) : "");
		}

		@@ -20,41 +21,41 @@
		@Since("2.2-dev34")
		public class EffFeed extends Effect {

Uh oh!

Uh oh!

Conversation

hotpoc commented Jun 12, 2026

Problem

Solution

Testing Completed

Supporting Information

Uh oh!

This comment has been minimized.

AnOwlBe commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheMug06 commented Jun 12, 2026

Uh oh!

TheMug06 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AnOwlBe commented Jun 12, 2026

Uh oh!

TheMug06 commented Jun 12, 2026

Uh oh!

Uh oh!

hotpoc commented Jun 13, 2026

Uh oh!

AnOwlBe commented Jun 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnOwlBe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnOwlBe Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AnOwlBe commented Jun 12, 2026 •

edited

Loading

AnOwlBe Jun 30, 2026 •

edited

Loading