Skip to content

feat: update base image for dependency installation to Node.js 22-alpine#19

Merged
Adhish-Krishna merged 2 commits into
masterfrom
development
Jun 20, 2026
Merged

feat: update base image for dependency installation to Node.js 22-alpine#19
Adhish-Krishna merged 2 commits into
masterfrom
development

Conversation

@Adhish-Krishna

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93bc389189

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dashboard/Dockerfile
# Stage 1: Install dependencies
# ==========================================
FROM node:20-alpine AS deps
FROM node:22-alpine AS deps

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use Node 22 for every dashboard Docker stage

Changing only the deps stage leaves the image building and running under node:20-alpine while reusing node_modules installed by Node 22. Since dashboard/package.json declares engines.node as >=22.0.0, the Docker image produced by the existing dashboard build still runs the app on an unsupported Node version and can break as soon as the app or dependencies rely on Node 22 behavior; update the builder and runner stages to the same Node 22 base image as well.

Useful? React with 👍 / 👎.

@Adhish-Krishna Adhish-Krishna merged commit c365a65 into master Jun 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant