Add repository guidelines, update github actions to include lint-core and lint-dashboard, update node version requirement on all packages to 22+ and added .nvmrc for nvm to read node version#18
Conversation
…mmands, and testing practices
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6366baac27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| branches: | ||
| - main | ||
| - master | ||
| - development |
There was a problem hiding this comment.
If this repository still accepts pushes or PRs against the existing main branch, this trigger no longer matches them: the workflow now only runs for master and development, while the previous workflow included main. That would skip the added lint jobs, tests, and Docker image publishing for main-targeted changes, so keep main in this list until that branch is actually retired.
Useful? React with 👍 / 👎.
| "engines": { | ||
| "node": ">=22.0.0" | ||
| }, |
There was a problem hiding this comment.
The dashboard package now declares node >=22, but the image built and pushed by this workflow still comes from dashboard/Dockerfile, whose deps, builder, and runner stages are all node:20-alpine (dashboard/Dockerfile:4, :15, :33). This ships the dashboard on a runtime the package says is unsupported; Node 22-only code or dependencies can pass local/CI lint under Node 22 but fail in the published container, so either update the Dockerfile to Node 22 or do not raise the dashboard engine requirement.
Useful? React with 👍 / 👎.
1 participant
No description provided.