Repository navigation
F/multichannel notifications - #3
Merged
Merged
Conversation
Replace the lucasmenendez/apihandler dependency with go.k7z7z.cc/x. Remove internal packages that become redundant (base64url, error, fakesmtpserver, osflag). Remove the api/io package and cmd/consts.go. Adapt the token package to use go.k7z7z.cc/x imports for base64url encoding and error types.
Introduce a generic notification queue with Notification and QueueConfig interfaces. Implement the email notification channel with EmailConfig, EmailNotification, and SMTP sending with retries. Move login email templates under the email package. Adapt the API handlers, service, errors, and types to use the new notification system.
Update the client package to use the new api type structures and error types from go.k7z7z.cc/x. Replace internal error references with the new client sentinel errors.
Update authapi and demo entrypoints to use the generic notification queue and new email config types. Update example.env, docker files, and gitignore to reflect the new configuration layout.
Add tests for notification queue lifecycle, email channel error paths, template composition errors, token extraction, API handler error branches, service start/stop, and client HTTP errors. Rename test error variables to follow Go convention (errFoo).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.