Skip to content

Nova 4 compatibility - #71

Open
Grafikart wants to merge 2 commits into
Silvanite:masterfrom
ciklik:nova-4
Open

Nova 4 compatibility#71
Grafikart wants to merge 2 commits into
Silvanite:masterfrom
ciklik:nova-4

Conversation

@Grafikart

@Grafikart Grafikart commented May 10, 2022

Copy link
Copy Markdown

I updated the tool definition to make this plugin compatible with nova4. This break things so it requires a major version number.

novacheckboxes had to be updated before, I already submitted a PR for this Silvanite/novafieldcheckboxes#45

@gbrits

gbrits commented May 24, 2022

Copy link
Copy Markdown
Contributor

@Grafikart I'm running into a Class App\Nova\Role not found error and lapse in function unless I copy the Role resource from src-php into my Nova resources folder, but it feels hack. Also updating roles is not working on my implementation, do you know what is wrong on my set-up? I'm currently pulling your PR commit dev-nova-4 as my package until this PR merges.

@gbrits

gbrits commented May 24, 2022

Copy link
Copy Markdown
Contributor

Screen Shot 2022-05-24 at 12 37 29

As you can see here, in Nova 4.0, my rendering has some issues - but I would have assumed you'd have fixed these in your PR - so I'm guessing there's something wrong with the way I've set up. I did manually create my role model & my role nova resource as I assumed they were missing.

@gbrits

gbrits commented May 24, 2022

Copy link
Copy Markdown
Contributor

@Grafikart also, unfortunately it seems the update to dev-nova-4 for the checkboxes doesn't appear to allow unchecking to work fine? Can you add & remove role permissions fine on your app?

@kenshikento

Copy link
Copy Markdown

Issue with unchecking box [novafieldcheckboxes] is that in vue 3 instance method has been removed and they changed it to a "proxy-based change detection." u can just update the property the normal way.

@Grafikart

Copy link
Copy Markdown
Author

I saw that nova 4 has a boolean group field, we could use it instead of the novafieldcheckboxes.

@vladles

vladles commented Jul 20, 2022

Copy link
Copy Markdown

Any updates on this?

@kenshikento

kenshikento commented Jul 22, 2022

Copy link
Copy Markdown

Atm seems like package isn't being maintained really the only issue is the boolean field so u can replace it with native version. Just that styling isn't great doesn't seem to be a way to change it(since its only one column). If you still want to use
novafieldcheckboxes update aren't too far away just that the package is also not maintained.

yayann added a commit to SGS-Optimisation/novatoolpermissions that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants