fix(spotify): update stale test to match current API signatures - #38
Open
narayandesai wants to merge 1 commit into
Open
narayandesai wants to merge 1 commit into
narayandesai wants to merge 1 commit into
Conversation
Pre-existing test called YtMusicApi::new_oauth/SpotifyApi::new with an outdated argument list, which failed to compile and blocked cargo test for the entire crate. Fixed signatures and marked #[ignore] since it requires live credentials and a real playlist to run.
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spotify::tests::test_spotify_search_from_ytmusiccalledYtMusicApi::new_oauthandSpotifyApi::newwith an outdated argument list, causing a compile error in the test target and blockingcargo testfor the entire crate.ConfigArgs/PathBuf/redirect_uri/clear_cachearguments) and marked the test#[ignore]since it requires liveYTMUSIC_*/SPOTIFY_*credentials and a realTestSpotifyplaylist to run.Test plan
cargo testcompiles and runs cleanly (test is ignored by default, as before it would have needed live credentials to even get that far)