Repository navigation
Restart app on Doppler config changes via doppler run --watch - #143
Merged
Merged
Conversation
App-only secrets now rotate with just a Doppler update: the CLI restarts the JVM in place when the prd config changes. nginx/p12-coupled secrets still require an ansible re-converge, as documented in the entrypoint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the container entrypoint to run the Spring Boot JAR under doppler run --watch so the JVM is restarted in-place when Doppler prd secrets/config change, allowing runtime secret rotation without a redeploy.
Changes:
- Add
--watch(beta) to thedoppler runwrapper inentrypoint.sh. - Document operational caveats around batching secret updates and handling nginx/PKCS#12-coupled secrets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # one `doppler secrets set K1=… K2=…` call (each change event = one restart), and | ||
| # rotate nginx/p12-coupled secrets (proxy secret, keystore password) via an ansible | ||
| # re-converge instead — a watch restart alone would leave nginx/p12 out of sync. | ||
| exec doppler run --watch --fallback /opt/api-server/doppler-fallback.json -- java -jar api-server.jar |
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--watch(BETA) todoppler runin the entrypoint: the CLI holds a connection to Doppler and restarts the JVM in place whenever theprdconfig changes, so app-only secrets (Mongo URI, R2 keys, GitHub tokens, mail creds) rotate with nothing but a Doppler update — same brief 502 window as a deploy.Caveats documented in the entrypoint comment:
doppler secrets set K1=… K2=…call (each change event triggers one restart)APP_MTLS_PROXY_SECRET,APP_TLS_KEYSTORE_PASSWORD) must still go through an ansible re-converge — a watch restart alone would leave nginx/the keystore out of syncVerified locally that
--watch --fallbackcombine cleanly and the wrapped process runs and exits normally (doppler CLI v3.76.0).🤖 Generated with Claude Code