Skip to content

fix(vscode): avoid automatic Shopify login prompts - #1322

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/fix-vscode-metafields-login-1247
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/fix-vscode-metafields-login-1247

Conversation

@efegokdemir

Copy link
Copy Markdown

Fixes #1247

Opening a theme workspace currently triggers shopify theme metafields pull. If Shopify CLI is not authenticated, this can open a browser login during every VS Code startup, even when a user only needs local Liquid editor features.

Automatic metafield fetching is now opt-in through themeCheck.fetchMetafieldDefinitions (default: false). Users who want remote metafield completions can enable it; the existing fetch path remains available.

Regression coverage verifies that the fetch is skipped by default and still runs when the setting is enabled.

Validation:

  • vitest run packages/theme-language-server-common/src/server/startServer.spec.ts — 9 tests passed
  • Prettier check for changed TypeScript, package JSON, and changeset — passed
  • git diff --check — passed
  • Extension package.json parses as valid JSON
  • Type-check was attempted but could not complete in the isolated worktree because referenced workspace declaration outputs and matching local dependency types were unavailable.

@efegokdemir
efegokdemir requested a review from a team as a code owner October 3, 2026 12:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extensions opens log-in dialog with every VSCode start

1 participant