Skip to content

fix(theme-graph): report Liquid parse failures - #1321

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/theme-graph-report-parse-failures
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/theme-graph-report-parse-failures

Conversation

@efegokdemir

Copy link
Copy Markdown

What are you adding in this PR?

When a Liquid file cannot be parsed, buildThemeGraph now records its URI and parser message in parseErrors, and serializeThemeGraph includes those diagnostics in the CLI JSON output. This prevents an incomplete graph from silently presenting the file as dependency-free.

Adds a regression test using a malformed Liquid section that references an asset; it verifies the parse failure is reported while graph construction remains non-throwing.

Fixes #1290

What did you learn?

An unparseable file must be distinguishable from a file with no dependencies.

Before you deploy

  • I included a patch bump changeset
  • Relevant tests, type-check, build, formatting, and git diff --check pass.

@efegokdemir
efegokdemir requested a review from a team as a code owner October 3, 2026 11:42

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

theme-graph: parse failures silently produce an incomplete graph, causing false dead-code results

1 participant