Add block settings caller migration guidance - #1313
Merged
Merged
Conversation
charlespwd
marked this pull request as ready for review
September 30, 2026 15:01
clauderic
approved these changes
Sep 30, 2026
karreiro
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Give caller-side
block.settings.<id>:arguments a setting-specific Theme Check error that teaches the supported plain<id>:syntax.Problem
The generic dotted-argument error explains that block calls use plain arguments, but authors migrating existing themes still have to infer the exact edit. For
block.settings.heading: value, we can point directly from the old form toheading: value.Solution
Exact
block.settings.<id>caller arguments now report:The diagnostic remains on the first offending argument and still suppresses cascading block parameter errors. Other dotted caller names keep the generic error, and callee-side
block.settings.<id>expressions are unchanged.This includes a patch changeset for
@shopify/theme-check-common.Before merge
Record the release milestone or cleanup issue that will remove this temporary migration copy.